Skip to content

Commit c4f1694

Browse files
tmeisenhitaloacasas
authored andcommitted
test: add message verification on assert.throws
Add regular expression for error message validation to instances of assert.throws() in test-assert.js. PR-URL: #10890 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 5ce2ac8 commit c4f1694

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

test/parallel/test-assert.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,16 @@ assert.doesNotThrow(makeBlock(a.deepEqual, /a/g, /a/g));
9090
assert.doesNotThrow(makeBlock(a.deepEqual, /a/i, /a/i));
9191
assert.doesNotThrow(makeBlock(a.deepEqual, /a/m, /a/m));
9292
assert.doesNotThrow(makeBlock(a.deepEqual, /a/igm, /a/igm));
93-
assert.throws(makeBlock(a.deepEqual, /ab/, /a/));
94-
assert.throws(makeBlock(a.deepEqual, /a/g, /a/));
95-
assert.throws(makeBlock(a.deepEqual, /a/i, /a/));
96-
assert.throws(makeBlock(a.deepEqual, /a/m, /a/));
97-
assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im));
93+
assert.throws(makeBlock(a.deepEqual, /ab/, /a/),
94+
/^AssertionError: \/ab\/ deepEqual \/a\/$/);
95+
assert.throws(makeBlock(a.deepEqual, /a/g, /a/),
96+
/^AssertionError: \/a\/g deepEqual \/a\/$/);
97+
assert.throws(makeBlock(a.deepEqual, /a/i, /a/),
98+
/^AssertionError: \/a\/i deepEqual \/a\/$/);
99+
assert.throws(makeBlock(a.deepEqual, /a/m, /a/),
100+
/^AssertionError: \/a\/m deepEqual \/a\/$/);
101+
assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im),
102+
/^AssertionError: \/a\/gim deepEqual \/a\/im$/);
98103

99104
{
100105
const re1 = /a/;

0 commit comments

Comments
 (0)