Skip to content

Commit d0fb02c

Browse files
Trotttargos
authored andcommitted
test: put common lint exceptions into config file
For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file. PR-URL: #39358 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent bbff5a9 commit d0fb02c

23 files changed

+3
-27
lines changed

test/common/.eslintrc.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
rules:
2+
node-core/required-modules: off
3+
node-core/require-common-first: off

test/common/arraystream.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const { Stream } = require('stream');

test/common/benchmark.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
'use strict';
42

53
const assert = require('assert');

test/common/countdown.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
'use strict';
42

53
const assert = require('assert');

test/common/cpu-prof.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
'use strict';
42

53
require('./');

test/common/dns.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const assert = require('assert');

test/common/duplexpair.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32
const { Duplex } = require('stream');
43
const assert = require('assert');

test/common/fixtures.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const path = require('path');

test/common/fixtures.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
import fixtures from './fixtures.js';
32

43
const {

test/common/heap.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32
const assert = require('assert');
43
const util = require('util');

test/common/hijackstdio.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
// Hijack stdout and stderr

test/common/http2.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
// An HTTP/2 testing tool used to create mock frames for direct testing

test/common/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

22-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2322
/* eslint-disable node-core/crypto-check */
2423
'use strict';
2524
const process = global.process; // Some tests tamper with the process global.

test/common/index.mjs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
import { createRequire } from 'module';
42

53
const require = createRequire(import.meta.url);

test/common/internet.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
// Utilities for internet-related tests

test/common/measure-memory.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const assert = require('assert');

test/common/report.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32
const assert = require('assert');
43
const fs = require('fs');

test/common/require-as.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
if (require.main !== module) {

test/common/tls.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
/* eslint-disable node-core/crypto-check */
32

43
'use strict';

test/common/tmpdir.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const fs = require('fs');

test/common/udppair.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32
const { internalBinding } = require('internal/test/binding');
43
const { JSUDPWrap } = internalBinding('js_udp_wrap');

test/common/wpt.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const assert = require('assert');

test/common/wpt/worker.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/required-modules,node-core/require-common-first */
2-
31
'use strict';
42

53
const { runInThisContext } = require('vm');

0 commit comments

Comments
 (0)