Skip to content

Commit d19b293

Browse files
committed
build: fix update-wpt workflow
1 parent 5d9b63d commit d19b293

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

.github/workflows/update-wpt.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@ jobs:
2727
subsystem: ${{ fromJSON(github.event.inputs.subsystems || '["url", "urlpattern", "WebCryptoAPI"]') }}
2828

2929
steps:
30-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
30+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
3131
with:
3232
persist-credentials: false
3333

3434
- name: Install Node.js
35-
uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0
35+
uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0
3636
with:
3737
node-version: ${{ env.NODE_VERSION }}
3838

@@ -70,7 +70,11 @@ jobs:
7070
- name: Open or update PR for the subsystem update
7171
uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
7272
with:
73-
branch: actions/update-wpt-${{ matrix.subsystem }}
73+
# The create-or-update-pull-request-action matches the branch name by prefix,
74+
# which is why we need to add the -wpt suffix. If we dont do that, we risk matching wrong PRs,
75+
# like for example "url" mistakenly matching and updating the "urlpattern" PR
76+
# as seen in https://github.com/nodejs/node/pull/57368
77+
branch: actions/update-${{ matrix.subsystem }}-wpt
7478
author: Node.js GitHub Bot <[email protected]>
7579
title: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}'
7680
commit-message: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}'

0 commit comments

Comments
 (0)