Skip to content

Commit d28003b

Browse files
peterwmwongBethGriggs
authored andcommitted
test: remove unused --expose-native-as V8 flag
test-preload.js was using a V8 flag (`--expose-native-as`) that made an V8 internally used object available. As this test does not use this object, this commit removes the usage of this flag. In some distant past, this internally used object may have had some external use, but currently is essentially an empty object. In the near future, the V8 internal infrastructure (JS Natives) producing the object exposed by `--expose-native-as` will be phased out. For more details, visit: https://bugs.chromium.org/p/v8/issues/detail?id=7624 PR-URL: #25275 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
1 parent 07724fe commit d28003b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-preload.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ childProcess.exec(
135135
// https://github.com/nodejs/node/issues/1691
136136
process.chdir(fixtures.fixturesDir);
137137
childProcess.exec(
138-
`"${nodeBinary}" --expose_natives_as=v8natives --require ` +
138+
`"${nodeBinary}" --require ` +
139139
`"${fixtures.path('cluster-preload.js')}" cluster-preload-test.js`,
140140
function(err, stdout, stderr) {
141141
assert.ifError(err);

0 commit comments

Comments
 (0)