Skip to content

Commit d2c8b3e

Browse files
lpincajasnell
authored andcommitted
doc: clarify that the ctx argument is optional
Clarify that the `ctx` argument of the `SNICallback` callback is optional. Fixes: #34085 PR-URL: #34097 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent d3d4ace commit d2c8b3e

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

doc/api/tls.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1696,12 +1696,15 @@ changes:
16961696
* `sessionTimeout` {number} The number of seconds after which a TLS session
16971697
created by the server will no longer be resumable. See
16981698
[Session Resumption][] for more information. **Default:** `300`.
1699-
* `SNICallback(servername, cb)` {Function} A function that will be called if
1700-
the client supports SNI TLS extension. Two arguments will be passed when
1701-
called: `servername` and `cb`. `SNICallback` should invoke `cb(null, ctx)`,
1702-
where `ctx` is a `SecureContext` instance. (`tls.createSecureContext(...)`
1703-
can be used to get a proper `SecureContext`.) If `SNICallback` wasn't
1704-
provided the default callback with high-level API will be used (see below).
1699+
* `SNICallback(servername, callback)` {Function} A function that will be
1700+
called if the client supports SNI TLS extension. Two arguments will be
1701+
passed when called: `servername` and `callback`. `callback` is an
1702+
error-first callback that takes two optional arguments: `error` and `ctx`.
1703+
`ctx`, if provided, is a `SecureContext` instance.
1704+
[`tls.createSecureContext()`][] can be used to get a proper `SecureContext`.
1705+
If `callback` is called with a falsy `ctx` argument, the default secure
1706+
context of the server will be used. If `SNICallback` wasn't provided the
1707+
default callback with high-level API will be used (see below).
17051708
* `ticketKeys`: {Buffer} 48-bytes of cryptographically strong pseudo-random
17061709
data. See [Session Resumption][] for more information.
17071710
* `pskCallback` {Function}

0 commit comments

Comments
 (0)