util: avoid out-of-bounds arguments index access

This updates util.inspect() to avoid accessing out-of-range indices of
the `arguments` object, which is known to cause optimization bailout.

Based on an average of 10 runs of the benchmark in
`benchmark/util/inspect.js`, this change improves the performance of
`util.inspect` by about 10%.

Relates to #10323

PR-URL: #10569
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: not-an-aardvark

lib/util.js

@@ -173,8 +173,12 @@ function inspect(obj, opts) {
     stylize: stylizeNoColor
   };
   // legacy...
-  if (arguments[2] !== undefined) ctx.depth = arguments[2];
-  if (arguments[3] !== undefined) ctx.colors = arguments[3];
+  if (arguments.length >= 3 && arguments[2] !== undefined) {
+    ctx.depth = arguments[2];
+  }
+  if (arguments.length >= 4 && arguments[3] !== undefined) {
+    ctx.colors = arguments[3];
+  }
   if (typeof opts === 'boolean') {
     // legacy...
     ctx.showHidden = opts;