Skip to content

Commit deb4127

Browse files
dnlupgireeshpunathil
authored andcommitted
child_process: replace var with let/const
PR-URL: #30389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 00e2276 commit deb4127

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

lib/child_process.js

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ function fork(modulePath /* , args, options */) {
5959
validateString(modulePath, 'modulePath');
6060

6161
// Get options and args arguments.
62-
var execArgv;
63-
var options = {};
64-
var args = [];
65-
var pos = 1;
62+
let execArgv;
63+
let options = {};
64+
let args = [];
65+
let pos = 1;
6666
if (pos < arguments.length && Array.isArray(arguments[pos])) {
6767
args = arguments[pos++];
6868
}
@@ -235,23 +235,23 @@ function execFile(file /* , args, options, callback */) {
235235
windowsVerbatimArguments: !!options.windowsVerbatimArguments
236236
});
237237

238-
var encoding;
238+
let encoding;
239239
const _stdout = [];
240240
const _stderr = [];
241241
if (options.encoding !== 'buffer' && Buffer.isEncoding(options.encoding)) {
242242
encoding = options.encoding;
243243
} else {
244244
encoding = null;
245245
}
246-
var stdoutLen = 0;
247-
var stderrLen = 0;
248-
var killed = false;
249-
var exited = false;
250-
var timeoutId;
246+
let stdoutLen = 0;
247+
let stderrLen = 0;
248+
let killed = false;
249+
let exited = false;
250+
let timeoutId;
251251

252-
var ex = null;
252+
let ex = null;
253253

254-
var cmd = file;
254+
let cmd = file;
255255

256256
function exithandler(code, signal) {
257257
if (exited) return;
@@ -265,8 +265,8 @@ function execFile(file /* , args, options, callback */) {
265265
if (!callback) return;
266266

267267
// merge chunks
268-
var stdout;
269-
var stderr;
268+
let stdout;
269+
let stderr;
270270
if (encoding ||
271271
(
272272
child.stdout &&
@@ -566,15 +566,15 @@ function spawnSync(file, args, options) {
566566
options.stdio = getValidStdio(options.stdio || 'pipe', true).stdio;
567567

568568
if (options.input) {
569-
var stdin = options.stdio[0] = { ...options.stdio[0] };
569+
const stdin = options.stdio[0] = { ...options.stdio[0] };
570570
stdin.input = options.input;
571571
}
572572

573573
// We may want to pass data in on any given fd, ensure it is a valid buffer
574-
for (var i = 0; i < options.stdio.length; i++) {
575-
var input = options.stdio[i] && options.stdio[i].input;
574+
for (let i = 0; i < options.stdio.length; i++) {
575+
const input = options.stdio[i] && options.stdio[i].input;
576576
if (input != null) {
577-
var pipe = options.stdio[i] = { ...options.stdio[i] };
577+
const pipe = options.stdio[i] = { ...options.stdio[i] };
578578
if (isArrayBufferView(input)) {
579579
pipe.input = input;
580580
} else if (typeof input === 'string') {
@@ -595,11 +595,11 @@ function spawnSync(file, args, options) {
595595

596596

597597
function checkExecSyncError(ret, args, cmd) {
598-
var err;
598+
let err;
599599
if (ret.error) {
600600
err = ret.error;
601601
} else if (ret.status !== 0) {
602-
var msg = 'Command failed: ';
602+
let msg = 'Command failed: ';
603603
msg += cmd || args.join(' ');
604604
if (ret.stderr && ret.stderr.length > 0)
605605
msg += `\n${ret.stderr.toString()}`;

0 commit comments

Comments
 (0)