Skip to content

Commit e16f95d

Browse files
TrottFishrock123
authored andcommitted
doc: update exercise portion of onboarding doc
PR-URL: #8559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
1 parent b0234e7 commit e16f95d

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

doc/onboarding.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -188,14 +188,15 @@ Landing a PR
188188
* Close the pull request with a "Landed in `<commit hash>`" comment.
189189

190190

191-
## exercise: make PRs adding yourselves to the README
191+
## Exercise: Make a PR adding yourself to the README
192192

193193
* Example: https://github.com/nodejs/node/commit/7b09aade8468e1c930f36b9c81e6ac2ed5bc8732
194-
* to see full URL: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1`
195-
* Collaborators in alphabetical order by username
196-
* Label your pull request with the `doc` subsystem label
197-
* If you would like to run CI on your PR, feel free to
198-
* Make sure to added the `PR-URL: <full-pr-url>`!
194+
* For raw commit message: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1`
195+
* Collaborators are in alphabetical order by GitHub username.
196+
* Label your pull request with the `doc` subsystem label.
197+
* Run CI on your PR.
198+
* After a `LGTM` or two, land the PR.
199+
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata!
199200

200201

201202
## final notes

0 commit comments

Comments
 (0)