Skip to content

Commit e408f0a

Browse files
nfriedlyitaloacasas
authored andcommitted
test: fix misplaced ) in http response statuscode test
This fixes a misplaced parenthesis in each of the tests in test/parallel/test-http-response-statuscodes.js, causing the tests to pass as long as any error was thrown, without validating the error message. PR-URL: #10692 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michal Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 4c8676b commit e408f0a

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

test/parallel/test-http-response-statuscode.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,62 +11,62 @@ const server = http.Server(common.mustCall(function(req, res) {
1111
case 0:
1212
assert.throws(common.mustCall(() => {
1313
res.writeHead(-1);
14-
}, /invalid status code/i));
14+
}), /invalid status code/i);
1515
break;
1616
case 1:
1717
assert.throws(common.mustCall(() => {
1818
res.writeHead(Infinity);
19-
}, /invalid status code/i));
19+
}), /invalid status code/i);
2020
break;
2121
case 2:
2222
assert.throws(common.mustCall(() => {
2323
res.writeHead(NaN);
24-
}, /invalid status code/i));
24+
}), /invalid status code/i);
2525
break;
2626
case 3:
2727
assert.throws(common.mustCall(() => {
2828
res.writeHead({});
29-
}, /invalid status code/i));
29+
}), /invalid status code/i);
3030
break;
3131
case 4:
3232
assert.throws(common.mustCall(() => {
3333
res.writeHead(99);
34-
}, /invalid status code/i));
34+
}), /invalid status code/i);
3535
break;
3636
case 5:
3737
assert.throws(common.mustCall(() => {
3838
res.writeHead(1000);
39-
}, /invalid status code/i));
39+
}), /invalid status code/i);
4040
break;
4141
case 6:
4242
assert.throws(common.mustCall(() => {
4343
res.writeHead('1000');
44-
}, /invalid status code/i));
44+
}), /invalid status code/i);
4545
break;
4646
case 7:
4747
assert.throws(common.mustCall(() => {
4848
res.writeHead(null);
49-
}, /invalid status code/i));
49+
}), /invalid status code/i);
5050
break;
5151
case 8:
5252
assert.throws(common.mustCall(() => {
5353
res.writeHead(true);
54-
}, /invalid status code/i));
54+
}), /invalid status code/i);
5555
break;
5656
case 9:
5757
assert.throws(common.mustCall(() => {
5858
res.writeHead([]);
59-
}, /invalid status code/i));
59+
}), /invalid status code/i);
6060
break;
6161
case 10:
6262
assert.throws(common.mustCall(() => {
6363
res.writeHead('this is not valid');
64-
}, /invalid status code/i));
64+
}), /invalid status code/i);
6565
break;
6666
case 11:
6767
assert.throws(common.mustCall(() => {
6868
res.writeHead('404 this is not valid either');
69-
}, /invalid status code/i));
69+
}), /invalid status code/i);
7070
this.close();
7171
break;
7272
default:

0 commit comments

Comments
 (0)