Skip to content

Commit e9e3390

Browse files
miladfarcaaddaleax
authored andcommitted
deps: V8: backport 3f071e3e7e15
Original commit message: PPC: Optimize clearing higher bits of mulhw/mulhwu Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468 Reviewed-by: Junliang Yan <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/master@{#69343} Refs: v8/v8@3f071e3 Backport-PR-URL: #35305 PR-URL: #35305 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
1 parent 57564eb commit e9e3390

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
# Reset this number to 0 on major V8 upgrades.
3636
# Increment by one for each non-official patch applied to deps/v8.
37-
'v8_embedder_string': '-node.41',
37+
'v8_embedder_string': '-node.42',
3838

3939
##### V8 defaults for Node.js #####
4040

deps/v8/src/compiler/backend/ppc/code-generator-ppc.cc

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1480,12 +1480,14 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
14801480
}
14811481
break;
14821482
case kPPC_MulHigh32:
1483-
__ mulhw(i.OutputRegister(), i.InputRegister(0), i.InputRegister(1),
1484-
i.OutputRCBit());
1483+
__ mulhw(r0, i.InputRegister(0), i.InputRegister(1), i.OutputRCBit());
1484+
// High 32 bits are undefined and need to be cleared.
1485+
__ clrldi(i.OutputRegister(), r0, Operand(32));
14851486
break;
14861487
case kPPC_MulHighU32:
1487-
__ mulhwu(i.OutputRegister(), i.InputRegister(0), i.InputRegister(1),
1488-
i.OutputRCBit());
1488+
__ mulhwu(r0, i.InputRegister(0), i.InputRegister(1), i.OutputRCBit());
1489+
// High 32 bits are undefined and need to be cleared.
1490+
__ clrldi(i.OutputRegister(), r0, Operand(32));
14891491
break;
14901492
case kPPC_MulDouble:
14911493
ASSEMBLE_FLOAT_BINOP_RC(fmul, MiscField::decode(instr->opcode()));

0 commit comments

Comments
 (0)