Skip to content

Commit f14fa1b

Browse files
committed
node-api: generalize finalizer second pass callback
Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <[email protected]>
1 parent a1b27b2 commit f14fa1b

File tree

8 files changed

+317
-413
lines changed

8 files changed

+317
-413
lines changed

node.gyp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1003,7 +1003,6 @@
10031003
'test/cctest/test_base_object_ptr.cc',
10041004
'test/cctest/test_node_postmortem_metadata.cc',
10051005
'test/cctest/test_environment.cc',
1006-
'test/cctest/test_js_native_api_v8.cc',
10071006
'test/cctest/test_linked_binding.cc',
10081007
'test/cctest/test_node_api.cc',
10091008
'test/cctest/test_per_process.cc',

0 commit comments

Comments
 (0)