Use template strings and const instead of var

See comments to PR #3929

Author: rsp

test/parallel/test-fs-long-path.js

@@ -1,24 +1,24 @@
 'use strict';
-var common = require('../common');
-var fs = require('fs');
-var path = require('path');
-var assert = require('assert');
-var os = require('os');
+const common = require('../common');
+const fs = require('fs');
+const path = require('path');
+const os = require('os');
 
 // when it fails test again under real OS tmp dir on Linux when it is
 // readable/writable to avoid failing tests on ecryptfs filesystems:
 // https://github.com/nodejs/node/issues/2255
 // it follows advice in comments to:
 // https://github.com/nodejs/node/pull/3925
+// https://github.com/nodejs/node/pull/3929
 try {
   common.refreshTmpDir();
   testFsLongPath(common.tmpDir);
   common.refreshTmpDir();
 } catch (e) {
   if (os.type() == 'Linux') {
     fs.accessSync(os.tmpdir(), fs.R_OK | fs.W_OK);
-    var tmpDir = path.join(os.tmpdir(),
-      'node-' + process.version + '-test-' + (Math.random() * 1e6 | 0));
+    const tmpDir = path.join(os.tmpdir(),
+      `node-${process.version}-test-${1e6 * Math.random() | 0}`);
     fs.mkdirSync(tmpDir);
     testFsLongPath(tmpDir);
     fs.rmdirSync(tmpDir);
@@ -30,9 +30,9 @@ try {
 function testFsLongPath(tmpDir) {
 
   // make a path that will be at least 260 chars long.
-  var fileNameLen = Math.max(260 - tmpDir.length - 1, 1);
-  var fileName = path.join(tmpDir, new Array(fileNameLen + 1).join('x'));
-  var fullPath = path.resolve(fileName);
+  const fileNameLen = Math.max(260 - tmpDir.length - 1, 1);
+  const fileName = path.join(tmpDir, new Array(fileNameLen + 1).join('x'));
+  const fullPath = path.resolve(fileName);
 
   console.log({
     filenameLength: fileName.length,

test/parallel/test-require-long-path.js

@@ -7,17 +7,18 @@ const os = require('os');
 // when it fails test again under real OS tmp dir on Linux when it is
 // readable/writable to avoid failing tests on ecryptfs filesystems:
 // https://github.com/nodejs/node/issues/2255
-// it takes into account comments in:
+// it follows advice in comments to:
 // https://github.com/nodejs/node/pull/3925
+// https://github.com/nodejs/node/pull/3929
 try {
   common.refreshTmpDir();
   testRequireLongPath(common.tmpDir);
   common.refreshTmpDir();
 } catch (e) {
   if (os.type() == 'Linux') {
     fs.accessSync(os.tmpdir(), fs.R_OK | fs.W_OK);
-    var tmpDir = path.join(os.tmpdir(),
-      'node-' + process.version + '-test-' + (Math.random() * 1e6 | 0));
+    const tmpDir = path.join(os.tmpdir(),
+      `node-${process.version}-test-${1e6 * Math.random() | 0}`);
     fs.mkdirSync(tmpDir);
     testRequireLongPath(tmpDir);
     fs.rmdirSync(tmpDir);