src: improve error message for invalid child stdio type in spawn_sync

dario-piotrowicz · dario-piotrowicz · commit fb26425eb12d · 2025-03-22T17:30:15.000Z
diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc
@@ -1055,7 +1055,10 @@ Maybe<int> SyncProcessRunner::ParseStdioOption(int child_fd,
     return Just(AddStdioInheritFD(child_fd, inherit_fd));
   }
 
-  UNREACHABLE("invalid child stdio type");
+  Utf8Value stdio_type(env()->isolate(), js_type);
+  fprintf(stderr, "invalid child stdio type: %s\n", stdio_type.out());
+
+  UNREACHABLE();
 }
 
 int SyncProcessRunner::AddStdioIgnore(uint32_t child_fd) {

Original file line number	Diff line number	Diff line change
`@@ -1055,7 +1055,10 @@ Maybe<int> SyncProcessRunner::ParseStdioOption(int child_fd,`
`1055`	`1055`	`return Just(AddStdioInheritFD(child_fd, inherit_fd));`
`1056`	`1056`	`}`
`1057`	`1057`
`1058`		`- UNREACHABLE("invalid child stdio type");`
	`1058`	`+ Utf8Value stdio_type(env()->isolate(), js_type);`
	`1059`	`+ fprintf(stderr, "invalid child stdio type: %s\n", stdio_type.out());`
	`1060`	`+`
	`1061`	`+ UNREACHABLE();`
`1059`	`1062`	`}`
`1060`	`1063`
`1061`	`1064`	`int SyncProcessRunner::AddStdioIgnore(uint32_t child_fd) {`