Skip to content

Commit ffa874f

Browse files
committed
fs: avoid error swallowing when closing file
1 parent 08a2383 commit ffa874f

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

lib/fs.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1458,13 +1458,10 @@ function writeAll(fd, isUserFd, buffer, offset, length, signal, callback) {
14581458
// write(fd, buffer, offset, length, position, callback)
14591459
fs.write(fd, buffer, offset, length, null, (writeErr, written) => {
14601460
if (writeErr) {
1461-
if (isUserFd) {
1462-
callback(writeErr);
1463-
} else {
1464-
fs.close(fd, function close() {
1465-
callback(writeErr);
1466-
});
1461+
if (!isUserFd) {
1462+
fs.close(fd);
14671463
}
1464+
callback(writeErr);
14681465
} else if (written === length) {
14691466
if (isUserFd) {
14701467
callback(null);

0 commit comments

Comments
 (0)