Skip to content

HTTP Client cleanup #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronkorving opened this issue Aug 16, 2015 · 3 comments
Closed

HTTP Client cleanup #2400

ronkorving opened this issue Aug 16, 2015 · 3 comments
Labels
http Issues or PRs related to the http subsystem. question Issues that look for answers.

Comments

@ronkorving
Copy link
Contributor

Hi guys,

I'm working on some cleanup for the http client code, hoping to improve performance and maintainability. I have one question though. Why does the ClientRequest have an isArray check on options.headers? It seems like that is never the case.

It originated in nodejs/node-v0.x-archive@b09c588 by @creationix. I'm hoping there's someone around who could explain to me what the purpose of this test is (perhaps @creationix himself?).

Thank you.
@ChALkeR ChALkeR added question Issues that look for answers. http Issues or PRs related to the http subsystem. labels Aug 16, 2015
@ChALkeR
Copy link
Member

ChALkeR commented Aug 16, 2015

See #1292 (wasn't merged).

@ronkorving
Copy link
Contributor Author

Thanks, that answers it.

@ronkorving
Copy link
Contributor Author

I've left my comments there. I think the array behavior is broken and a solution (one of two) is warranted.

@arturgawlik arturgawlik mentioned this issue May 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. question Issues that look for answers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChALkeR @ronkorving