Skip to content

v22.x-staging cherry-pick status #57799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RafaelGSS opened this issue Apr 8, 2025 · 2 comments
Open

v22.x-staging cherry-pick status #57799

RafaelGSS opened this issue Apr 8, 2025 · 2 comments
Labels
release-agenda Issues and PRs to discuss during the meetings of the Release team. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Comments

@RafaelGSS
Copy link
Member

v22.x-staging Cherry-pick Report

100 successfully cherry-picked commits:

65 commits that failed to cherry-pick:

3 commits that were ignored:

  • f2ad4d3af8
  • 4e4b0c63d0
  • 4e4b0c63d0%
@RafaelGSS RafaelGSS added the v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. label Apr 8, 2025
@RafaelGSS
Copy link
Member Author

RafaelGSS commented Apr 8, 2025

@ruyadorno I have run it with:

➜  node (v22.x-staging) ncu-config get branch
v22.x-staging
➜  node (v22.x-staging) ../node-core-utils/bin/git-node.js staging

Failures:

  • As we have discussed, it doesn't consider 2 weeks of baking time for LTS. However, this is using the next subsequent release line as comparison, in this case, v22.x. So, we have 1 week of baking time for this specific release.
  • The report is failing to be created automatically on Github. I had to do it myself.
  • Even without using --skipGH, the backport-requested labels are not placed automatically. I'll need to do it myself.
  • Having to do a git cherry-pick --skip/--continue && git node staging --skip/--continue doesn't seem ideal. What about having git node staging --skip and it performs the git cherry-pick behind the scenes?
  • The report is also duplicating the commit in the list

cc: @nodejs/releasers

@ruyadorno
Copy link
Member

I'll bring these points as TODO in the original PR 👍 thanks for the test run @RafaelGSS!

@RafaelGSS RafaelGSS added the release-agenda Issues and PRs to discuss during the meetings of the Release team. label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-agenda Issues and PRs to discuss during the meetings of the Release team. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

No branches or pull requests

2 participants