v22.x-staging cherry-pick status #57799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

RafaelGSS opened this issue Apr 8, 2025 · 2 comments

Labels

release-agenda v22.x

Member

RafaelGSS commented Apr 8, 2025

`v22.x-staging` Cherry-pick Report

100 successfully cherry-picked commits:

b94c7bfc0a7 deps: update amaro to 0.3.1 lib / src, needs-ci, dependencies, strip-types
be6918da131 src: use a default thread name for inspector lib / src, notable-change, author ready, needs-ci, commit-queue-rebase
4adf96fd133 src: set worker thread name using worker.name lib / src, notable-change, author ready, needs-ci, commit-queue-rebase
e786e8eb7cf src: set thread name for main thread and v8 worker lib / src, notable-change, author ready, needs-ci, commit-queue-rebase
d52f5e702e0 src: set signal inspector io thread name lib / src, notable-change, author ready, needs-ci, commit-queue-rebase
9785644a342 src: remove obsolete NoArrayBufferZeroFillScope c++, author ready, needs-ci
3998781f52c deps: update amaro to 0.3.2 c++, doc, author ready, needs-ci, dependencies, commit-queue-rebase, strip-types
888d2acc3a doc: specificy support for erasable ts syntax c++, doc, author ready, needs-ci, dependencies, commit-queue-rebase, strip-types
7353266b50 doc: improve type stripping documentation c++, doc, author ready, needs-ci, dependencies, commit-queue-rebase, strip-types
ba3cff49ed9 test: update snapshots for amaro v0.3.2 c++, doc, author ready, needs-ci, dependencies, commit-queue-rebase, strip-types
5cea5f209c4 test_runner: print formatted errors on summary author ready, needs-ci, commit-queue-squash, dont-land-on-v18.x, test_runner, dont-land-on-v20.x
4b02fdc72f doc: update Xcode version used for arm64 and pkg doc, build, fast-track, backported-to-v18.x, lts-watch-v20.x, lts-watch-v22.x
a2bb6471e5b process: add threadCpuUsage c++, semver-minor, process, lib / src, needs-ci
116c1fe84c test_runner: refactor testPlan counter increse author ready, needs-ci, commit-queue-squash, test_runner
b27929d87e1 deps: update amaro to 0.4.1 lib / src, needs-ci, dependencies, commit-queue-rebase, strip-types
92daab9e3fb test: module syntax should throw lib / src, needs-ci, dependencies, commit-queue-rebase, strip-types
fd49144378 tools: extract target abseil to abseil.gyp v8 engine, tools, needs-ci
8847f01dc2d test: skip uv-thread-name on IBM i test, addons, author ready, needs-ci
21b6423b9b sqlite: reset statement immediately in run() c++, author ready, sqlite
460f4f3bc8e win,test: disable test case failing with ClangCL windows, test, fast-track, needs-ci
f694d7de0e assert: improve partialDeepStrictEqual assert, util, semver-minor, notable-change, author ready, needs-ci, commit-queue-rebase, backported-to-v23.x
2c974b8c9da benchmark: add assert partialDeepStrictEqual benchmark assert, util, semver-minor, notable-change, author ready, needs-ci, commit-queue-rebase, backported-to-v23.x
09443a70f14 benchmark: skip running some assert benchmarks by default assert, util, semver-minor, notable-change, author ready, needs-ci, commit-queue-rebase, backported-to-v23.x
2dfc7e0c600 benchmark: adjust assert runtimes assert, util, semver-minor, notable-change, author ready, needs-ci, commit-queue-rebase, backported-to-v23.x
314b74c2040 assert,util: improve performance assert, util, semver-minor, notable-change, author ready, needs-ci, commit-queue-rebase, backported-to-v23.x
b91a8fd0108 assert: implement partial error comparison assert, util, semver-minor, notable-change, author ready, needs-ci, commit-queue-rebase, backported-to-v23.x
5c362225651 doc: add note about sync nodejs-private branches doc, author ready
a262adad9cc timers: remove unused parameter from insertGuarded timers, author ready, needs-ci
3fd633c3d0b doc: fix small typo in process.md doc, process, author ready
1f3febca1f2 tls: remove unnecessary type check on normalize tls, author ready, needs-ci
10722bc20e3 doc: add missing deprecated badges in fs.md doc, fs, author ready, backported-to-v18.x, lts-watch-v20.x
1688a2b722f src: cleanup aliased_buffer.h c++, author ready, needs-ci
44072ccbb1f doc: update maintaining-openssl.md for openssl meta
1ca8271c2a7 meta: move ovflowd to emeritus doc, fast-track, author ready
d68b8e1327f deps: update acorn to 8.14.1 lib / src, needs-ci, dependencies
183711c49f1 deps: update googletest to 0bdccf4 test, author ready, needs-ci, dependencies
c6efcd038bf lib: make getCallSites sourceMap option truly optional util, needs-ci
96e3d8a33d8 doc: explicit mention arbitrary code execution as a vuln doc, author ready
2cd6f583915 deps: update ada to v3.2.1 lib / src, author ready, needs-ci, commit-queue-squash
39e40cedce8 doc: fix typo in sqlite.md doc, experimental, fast-track, sqlite
3ab4a3a0e25 doc: remove typo YAML snippet from tls.getCACertificates doc tls, doc, fast-track, author ready
2cea0cd0af0 doc: add history info for --use-system-ca doc, cli, author ready, commit-queue-squash
30e4b52edf3 doc: fix typo in url.md doc, url, fast-track, author ready
486d083c564 tools: bump @babel/helpers from 7.26.9 to 7.26.10 in /tools/eslint tools, author ready, dependencies, javascript
ed49f1fe389 build: fix update-wpt workflow meta, fast-track, author ready
4aa03c86f45 src: define urlpattern components using a macro c++, whatwg-url, author ready, needs-ci, commit-queue-rebase
4ef7922e4cd fs: apply exclude function to root path fs, needs-ci, commit-queue-squash
ea5e805101c doc: add review guidelines for collaborator nominations meta, author ready
43bea6bb80 deps: V8: cherry-pick c172ffc5bf54 build, v8 engine, needs-ci, commit-queue-failed, lts-watch-v22.x
6040858266a http: coerce content-length to number http, author ready, needs-ci
291fb48dbdf doc: fixed the incorrect splitting of multiple words doc, author ready
f74e053be69 crypto: ensure expected JWK alg in SubtleCrypto.importKey RSA imports confirmed-bug, crypto, author ready, needs-ci, webcrypto, web-standards
eeb60686e80 cli: clarify --cpu-prof-name allowed values doc, cli
fca3430a58b test: update parallel/test-tls-dhe for OpenSSL 3.5 test, author ready, needs-ci, lts-watch-v18.x, lts-watch-v20.x
0a6e78d5b30 doc: prefer to sign commits under nodejs repository doc, author ready, commit-queue-squash
936af489a06 url: fix constructor error message for URLPattern c++, whatwg-url, author ready, needs-ci, commit-queue-squash
0c5ec1782a1 sqlite: add StatementSync.prototype.columns() semver-minor, lib / src, experimental, author ready, sqlite
aa588990e62 lib: limit split function calls to prevent excessive array length lib / src, author ready, needs-ci, commit-queue-squash
47bcc6e2389 [sqlite: add DatabaseSync.prototypeSymbol.dispose](sqlite: add DatabaseSync.prototype[Symbol.dispose]() #57506) experimental, author ready, sqlite
e4793c78931 doc: add node.js streams references to Web Streams doc doc
c4bf109888f debugger: fix behavior of plain object exec in debugger repl repl, author ready, needs-ci, debugger
eb2dd98cc59 doc: add new writing-docs contributing md doc
534cce71810 doc: run license-builder meta, author ready
548a19923a0 doc: remove some inconsistencies in deprecations.md doc, author ready, deprecations
e058bb30ec7 doc: deprecate passing args to spawn and execFile doc, author ready, deprecations
7b41d49ab34 src: cache urlpattern properties c++, whatwg-url, author ready, needs-ci, commit-queue-failed
7d7856a712a sqlite: add DatabaseSync.prototype.isOpen c++, author ready, sqlite
49f2ac6b5c0 meta: edit collaborator nomination process meta, author ready, commit-queue-squash
7bb03b4d020 assert: improve partialDeepStrictEqual performance assert, benchmark, performance, author ready, needs-ci, commit-queue-squash
f69417937e7 util: expose diff function used by the assertion errors assert, util, semver-minor, notable-change, author ready, needs-ci
828691876b2 doc: remove mention of visa fees from onboarding doc doc, author ready
5611fe1b82c doc: recommend watching the collaborators repo in the onboarding doc doc, author ready, commit-queue-squash
acd905281b8 timers: remove unnecessary allocation of _onTimeout timers, author ready, needs-ci
f8661337e73 doc: remove mertcanaltin from Triagers doc
a15e96bf656 meta: remove collaborator self-nomination meta
d4670932fa2 doc: mark multiple experimental APIS as stable doc
4b8d6d0e31d util: avoid run debug when enabled is false util, author ready, needs-ci
2fc13f72057 doc: remove deprecated pattern in child_process.md child_process, doc, fast-track, author ready
10f861dd3b6 doc: add history entry for DEP0190 in child_process.md child_process, doc, author ready
00eaf3d3a7a lib: add warning when binding inspector to public IP net, inspector, needs-ci
f8aff90235 process: add execve c++, semver-minor, process, lib / src, tsc-agenda, needs-ci
e693396e5c0 sqlite: add support for unknown named parameters c++, author ready, sqlite
22b893e6a2c doc: module resolution pseudocode corrections doc, esm, commit-queue-squash
3f064bf65ed test: add more number cases for buffer.indexOf test, needs-ci
2dd6d8122c8 tools: update sccache to support GH cache changes meta, author ready, lts-watch-v20.x, lts-watch-v22.x
b4576a6f57 doc: remove cryptoStream API reference tls, doc, author ready
be1f27e50b4 test: update WPT for urlpattern to 6ceca69d26 test, author ready, needs-ci
e7beae97613 doc: update support channels meta, fast-track, commit-queue-squash
7fcb8529dd7 doc: add bjohansebas as triager doc, author ready
3340df6dc17 timers: optimize timer functions with improved argument handling timers, author ready, needs-ci, needs-benchmark-ci, commit-queue-squash
16715da88da meta: add some clarification to the nomination process meta
51d02558476 doc: add section stating that very stale PRs should be closed doc, commit-queue-squash
acffb1e9eb4 deps: update undici to 6.21.2 lib / src, needs-ci, lts-watch-v20.x, v23.x, lts-watch-v22.x
12d3981c977 doc: mention reports should align with Node.js CoC doc, author ready
6b7421e01db tools: remove stalled label on unstalled issues and PRs meta, fast-track, commit-queue
88075e21f69 doc: remove mention of --require not supporting ES modules doc, cli, author ready, commit-queue-failed, commit-queue-squash, dont-land-on-v18.x, lts-watch-v20.x
921041b284 doc: remove Corepack documentation doc, author ready, commit-queue-failed
0ad36949903 doc: clarify behaviour of node-api adjust function doc, node-api, author ready, commit-queue-squash
adc70630cc8 doc: add gurgunday as triager doc, author ready
097f2778aea tools: fix WPT update cron string meta, author ready

65 commits that failed to cherry-pick:

51938f023a src,loader,permission: throw on InternalWorker use doc
a9d80d43cb Signed-off-by: James M Snell [email protected] semver-minor, lib / src, author ready, quic
4e3052aeee quic: fixup errant LocalVector usage c++, author ready, needs-ci, quic
3b305f25f2 lib: filter node:quic from builtinModules when flag not used module, author ready, needs-ci
45692e9c7c Signed-off-by: James M Snell [email protected] lib / src, author ready, needs-ci
9624049414 src: pull in more electron boringssl adjustments c++, lib / src, author ready, needs-ci, commit-queue
01d732d629 sqlite: handle conflicting SQLite and JS errors c++, author ready, commit-queue-squash, sqlite
8410c955b7 sqlite: fix use-after-free in StatementSync due to premature GC c++, author ready, sqlite
8dc637681a PR-URL: https://github.com/nodejs/node/pull/56253 c++, author ready, commit-queue-squash, sqlite
9e60501f5e sqlite: fix coverity warnings related to backup() c++, author ready, sqlite
5414eb48b5 src: improve error handling in multiple files c++, lib / src, author ready, needs-ci
fec2d50308 build: add skip_apidoc_files and include QUIC build, needs-ci, commit-queue-failed
e0a91f631b src: gate all quic behind disabled-by-default compile flag build, tools, fast-track, author ready, needs-ci
aa817853cd lib: fixup more incorrect ERR_INVALID_ARG_VALUE uses fs, author ready, needs-ci, commit-queue-rebase
041a217a4d fs: fix rmSync error code c++, fs, author ready
4d86a42aa4 src: remove redundant qualifiers in src/quic c++, lib / src, author ready, needs-ci
433657de8c src: namespace config file flags c++, needs-ci, commit-queue-rebase, dont-land-on-v18.x, dont-land-on-v20.x, config
5a21fa4573 test: add more coverage to node_config_file
274c18a365 src: set default config as node.config.json c++, semver-minor, needs-ci, dont-land-on-v18.x, dont-land-on-v20.x, config
28792ee59a test: skip test-config-json-schema with quic author ready, needs-ci, quic, commit-queue-rebase
37664e8485 src: fix node_config_file.h compilation error in GN build c++, author ready, needs-ci
5c20dcc166 esm: fix module.exports export on CJS modules esm, needs-ci, backport-requested-v18.x, backport-requested-v20.x
3cff7f80bb src: suggest --use-system-ca when a certificate error occurs crypto, c++, needs-ci
5be80b1748 src: refine ncrypto more lib / src, author ready, needs-ci
4ab3c1690a src: cleanup crypto more lib / src, author ready, needs-ci
053cef70e0 crypto: add optional callback to crypto.diffieHellman crypto, c++, semver-minor, author ready, needs-ci
f8acf2dd2a src: make minor cleanups in compile_cache.cc c++, author ready, needs-ci
b9d9ee4da2 src: make minor cleanups in encoding_binding.cc
47296492ba doc: replace NOTEs that do not render properly doc, author ready
9611980f58 src: improve error handling in multiple files c++, lib / src, author ready, needs-ci
7f5e31645c src: ensure primordials are initialized exactly once c++, author ready
717c44dead doc: make stability labels more consistent doc, commit-queue-squash
7611fc14de crypto: fix output of privateDecrypt with zero-length data confirmed-bug, crypto, author ready, needs-ci, dependencies, webcrypto, commit-queue-squash
a9d80d43cb Signed-off-by: James M Snell [email protected]
4e3052aeee quic: fixup errant LocalVector usage
3b305f25f2 lib: filter node:quic from builtinModules when flag not used
45692e9c7c Signed-off-by: James M Snell [email protected]
9624049414 src: pull in more electron boringssl adjustments
01d732d629 sqlite: handle conflicting SQLite and JS errors
8410c955b7 sqlite: fix use-after-free in StatementSync due to premature GC
8dc637681a PR-URL: https://github.com/nodejs/node/pull/56253
9e60501f5e sqlite: fix coverity warnings related to backup()
5414eb48b5 src: improve error handling in multiple files
fec2d50308 build: add skip_apidoc_files and include QUIC
e0a91f631b src: gate all quic behind disabled-by-default compile flag
aa817853cd lib: fixup more incorrect ERR_INVALID_ARG_VALUE uses
041a217a4d fs: fix rmSync error code
4d86a42aa4 src: remove redundant qualifiers in src/quic
433657de8c src: namespace config file flags
5a21fa4573 test: add more coverage to node_config_file
274c18a365 src: set default config as node.config.json
28792ee59a test: skip test-config-json-schema with quic
37664e8485 src: fix node_config_file.h compilation error in GN build
5c20dcc166 esm: fix module.exports export on CJS modules
3cff7f80bb src: suggest --use-system-ca when a certificate error occurs
5be80b1748 src: refine ncrypto more
4ab3c1690a src: cleanup crypto more
053cef70e0 crypto: add optional callback to crypto.diffieHellman
f8acf2dd2a src: make minor cleanups in compile_cache.cc
b9d9ee4da2 src: make minor cleanups in encoding_binding.cc
47296492ba doc: replace NOTEs that do not render properly
9611980f58 src: improve error handling in multiple files
7f5e31645c src: ensure primordials are initialized exactly once
717c44dead doc: make stability labels more consistent
7611fc14de crypto: fix output of privateDecrypt with zero-length data

3 commits that were ignored:

f2ad4d3af8
4e4b0c63d0
4e4b0c63d0%

The text was updated successfully, but these errors were encountered:

RafaelGSS added the v22.x label

Member Author

RafaelGSS commented Apr 8, 2025 •

edited

Loading

@ruyadorno I have run it with:

➜  node (v22.x-staging) ncu-config get branch
v22.x-staging
➜  node (v22.x-staging) ../node-core-utils/bin/git-node.js staging

Failures:

As we have discussed, it doesn't consider 2 weeks of baking time for LTS. However, this is using the next subsequent release line as comparison, in this case, v22.x. So, we have 1 week of baking time for this specific release.
The report is failing to be created automatically on Github. I had to do it myself.
Even without using --skipGH, the backport-requested labels are not placed automatically. I'll need to do it myself.
Having to do a git cherry-pick --skip/--continue && git node staging --skip/--continue doesn't seem ideal. What about having git node staging --skip and it performs the git cherry-pick behind the scenes?
The report is also duplicating the commit in the list

cc: @nodejs/releasers

RafaelGSS mentioned this issue

Add git node staging command nodejs/node-core-utils#875

Open

Member

ruyadorno commented Apr 8, 2025

I'll bring these points as TODO in the original PR 👍 thanks for the test run @RafaelGSS!

RafaelGSS added the release-agenda label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment