From 9adad1c44a5dff96a743d9b9191bbe8f1a63b38b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 19 Apr 2017 10:45:21 -0700 Subject: [PATCH 1/3] test: minimize time for child_process benchmark test-benchmark-child-process sometimes times out on Windows in CI. Minimize the number of configurations that run so it will (hopefully) not time out anymore. --- test/sequential/test-benchmark-child-process.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/sequential/test-benchmark-child-process.js b/test/sequential/test-benchmark-child-process.js index 4acad7d0f7bd9c..5b0af4713bbf10 100644 --- a/test/sequential/test-benchmark-child-process.js +++ b/test/sequential/test-benchmark-child-process.js @@ -11,6 +11,8 @@ const runjs = path.join(__dirname, '..', '..', 'benchmark', 'run.js'); const child = fork(runjs, ['--set', 'dur=0.1', '--set', 'n=1', '--set', 'len=1', + '--set', 'params=1', + '--set', 'methodName=exec', 'child_process'], {env: {NODEJS_BENCHMARK_ZERO_ALLOWED: 1}}); child.on('exit', (code, signal) => { From 28a4412232a886391b97eb130a0dfa4f6c98d4f0 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 19 Apr 2017 11:40:01 -0700 Subject: [PATCH 2/3] squash: try execSync instead of sync for more Windows reliability? --- test/sequential/test-benchmark-child-process.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/sequential/test-benchmark-child-process.js b/test/sequential/test-benchmark-child-process.js index 5b0af4713bbf10..a6858cce837cdf 100644 --- a/test/sequential/test-benchmark-child-process.js +++ b/test/sequential/test-benchmark-child-process.js @@ -12,7 +12,7 @@ const child = fork(runjs, ['--set', 'dur=0.1', '--set', 'n=1', '--set', 'len=1', '--set', 'params=1', - '--set', 'methodName=exec', + '--set', 'methodName=execSync', 'child_process'], {env: {NODEJS_BENCHMARK_ZERO_ALLOWED: 1}}); child.on('exit', (code, signal) => { From 87dd4f02cd984f8231090a692a5185918bb3941c Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 19 Apr 2017 12:57:20 -0700 Subject: [PATCH 3/3] squash: dur=0 --- test/sequential/test-benchmark-child-process.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/sequential/test-benchmark-child-process.js b/test/sequential/test-benchmark-child-process.js index a6858cce837cdf..2314c89948c701 100644 --- a/test/sequential/test-benchmark-child-process.js +++ b/test/sequential/test-benchmark-child-process.js @@ -8,7 +8,7 @@ const path = require('path'); const runjs = path.join(__dirname, '..', '..', 'benchmark', 'run.js'); -const child = fork(runjs, ['--set', 'dur=0.1', +const child = fork(runjs, ['--set', 'dur=0', '--set', 'n=1', '--set', 'len=1', '--set', 'params=1',