From 2d5284dd522473f684050ba8694ccdc9a48e9841 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Sat, 17 Nov 2018 12:50:14 -0500 Subject: [PATCH 1/2] doc,meta: add issue template for flaky tests --- .github/ISSUE_TEMPLATE/5-flaky-test.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/5-flaky-test.md diff --git a/.github/ISSUE_TEMPLATE/5-flaky-test.md b/.github/ISSUE_TEMPLATE/5-flaky-test.md new file mode 100644 index 00000000000000..29a96794cceab4 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/5-flaky-test.md @@ -0,0 +1,20 @@ +--- +name: "\U0001F4AB Found a flaky test?" +about: Please provide information about the failure. + +--- + +* test file - [NAME_OF_TEST_WITH_SUITE (e.g. parallel/test-https)](https://github.com/nodejs/node/blob/master/test/NAME_OF_TEST_WITH_SUITE.js) +* ci job - [CI_JOB_DESCRIPTOR (e.g. aix/21613)](https://ci.nodejs.org/job/node-test-CI_JOB_DESCRIPTOR) +* ci worker - [CI_WORKER_NAME](https://ci.nodejs.org/computer/CI_WORKER_NAME/) +* output: + ``` + CI console output for the failing test. + Or content of JUnit test details page. + Note: should be indented with 2 spaces to align with * bullet point. + ``` From f7187f55c83a46cd72fa14bef38278374ae803ea Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Mon, 19 Nov 2018 19:52:03 -0500 Subject: [PATCH 2/2] fixup! simplify --- .github/ISSUE_TEMPLATE/5-flaky-test.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/5-flaky-test.md b/.github/ISSUE_TEMPLATE/5-flaky-test.md index 29a96794cceab4..7885821a98d468 100644 --- a/.github/ISSUE_TEMPLATE/5-flaky-test.md +++ b/.github/ISSUE_TEMPLATE/5-flaky-test.md @@ -12,9 +12,9 @@ Please fill in as much of the template below as you can. * test file - [NAME_OF_TEST_WITH_SUITE (e.g. parallel/test-https)](https://github.com/nodejs/node/blob/master/test/NAME_OF_TEST_WITH_SUITE.js) * ci job - [CI_JOB_DESCRIPTOR (e.g. aix/21613)](https://ci.nodejs.org/job/node-test-CI_JOB_DESCRIPTOR) * ci worker - [CI_WORKER_NAME](https://ci.nodejs.org/computer/CI_WORKER_NAME/) -* output: - ``` - CI console output for the failing test. - Or content of JUnit test details page. - Note: should be indented with 2 spaces to align with * bullet point. - ``` + +output: +``` +CI console output for the failing test. +Or content of JUnit test details page. +```