From b5a8c7ff38065c9d5d4c23855935035df36a73f3 Mon Sep 17 00:00:00 2001 From: Shubham Urkade Date: Tue, 27 Nov 2018 22:55:09 +0530 Subject: [PATCH 1/2] test: replace anonymous functions with arrows --- test/parallel/test-net-persistent-ref-unref.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-net-persistent-ref-unref.js b/test/parallel/test-net-persistent-ref-unref.js index 15b71f6d02fc15..8968b9ec964a38 100644 --- a/test/parallel/test-net-persistent-ref-unref.js +++ b/test/parallel/test-net-persistent-ref-unref.js @@ -6,7 +6,7 @@ const net = require('net'); const { internalBinding } = require('internal/test/binding'); const TCPWrap = internalBinding('tcp_wrap').TCP; -const echoServer = net.createServer(function(conn) { +const echoServer = net.createServer((conn) => { conn.end(); }); @@ -29,12 +29,12 @@ TCPWrap.prototype.unref = function() { echoServer.listen(0); -echoServer.on('listening', function() { +echoServer.on('listening', () => { const sock = new net.Socket(); sock.unref(); sock.ref(); sock.connect(this.address().port); - sock.on('end', function() { + sock.on('end', () => { assert.strictEqual(refCount, 0); echoServer.close(); }); From ee74c813a49631d160d1da4c582f5d0bba57bd6e Mon Sep 17 00:00:00 2001 From: Shubham Urkade Date: Wed, 28 Nov 2018 17:16:07 +0530 Subject: [PATCH 2/2] test: revert arrow function for echoServer.on --- test/parallel/test-net-persistent-ref-unref.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-net-persistent-ref-unref.js b/test/parallel/test-net-persistent-ref-unref.js index 8968b9ec964a38..5df661475e3eee 100644 --- a/test/parallel/test-net-persistent-ref-unref.js +++ b/test/parallel/test-net-persistent-ref-unref.js @@ -29,7 +29,7 @@ TCPWrap.prototype.unref = function() { echoServer.listen(0); -echoServer.on('listening', () => { +echoServer.on('listening', function() { const sock = new net.Socket(); sock.unref(); sock.ref();