From 9259c7eb08c8163eec293d7ac011a014470512f1 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Sat, 26 Mar 2022 16:54:13 +0000
Subject: [PATCH] buffer: remove mustMatch from Buffer.bytelength()

Buffer.bytelength() has an undocumented third parameterm `mustMatch`.
Remove it.

Closes: https://github.com/nodejs/node/issues/38536
---
 lib/buffer.js                           | 7 +++----
 test/parallel/test-buffer-bytelength.js | 2 +-
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/lib/buffer.js b/lib/buffer.js
index 57d6cddbaa2e6b..5722103fefbfd4 100644
--- a/lib/buffer.js
+++ b/lib/buffer.js
@@ -738,16 +738,15 @@ function byteLength(string, encoding) {
   }
 
   const len = string.length;
-  const mustMatch = (arguments.length > 2 && arguments[2] === true);
-  if (!mustMatch && len === 0)
+  if (len === 0)
     return 0;
 
   if (!encoding)
-    return (mustMatch ? -1 : byteLengthUtf8(string));
+    return byteLengthUtf8(string);
 
   const ops = getEncodingOps(encoding);
   if (ops === undefined)
-    return (mustMatch ? -1 : byteLengthUtf8(string));
+    return byteLengthUtf8(string);
   return ops.byteLength(string);
 }
 
diff --git a/test/parallel/test-buffer-bytelength.js b/test/parallel/test-buffer-bytelength.js
index 33cbb3268440a1..e7df93967d5b84 100644
--- a/test/parallel/test-buffer-bytelength.js
+++ b/test/parallel/test-buffer-bytelength.js
@@ -23,7 +23,7 @@ const vm = require('vm');
   );
 });
 
-assert.strictEqual(Buffer.byteLength('', undefined, true), -1);
+assert.strictEqual(Buffer.byteLength(''), 0);
 
 assert(ArrayBuffer.isView(new Buffer(10)));
 assert(ArrayBuffer.isView(new SlowBuffer(10)));