From 5143928b549605b69a313e15b6b31acbb819629f Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 30 Jun 2022 10:41:36 -0400 Subject: [PATCH 1/2] test: fix coverity warning in test Fix uninitialized pointer field warning in test Signed-off-by: Michael Dawson --- test/cctest/test_inspector_socket_server.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index 7d5d0929def26b..272650097bb4f6 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -306,6 +306,7 @@ class TestSocketServerDelegate : public SocketServerDelegate { const std::vector& target_ids) : harness_(server), targets_(target_ids), + server_(nullptr), session_id_(0) {} ~TestSocketServerDelegate() override { From c7f5519051507db81da8baaf77e0d2543944d824 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 30 Jun 2022 12:52:19 -0400 Subject: [PATCH 2/2] fixup: make linter happy Signed-off-by: Michael Dawson --- test/cctest/test_inspector_socket_server.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index 272650097bb4f6..451fbbd6acfc4d 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -301,9 +301,8 @@ class ServerHolder { class TestSocketServerDelegate : public SocketServerDelegate { public: - explicit TestSocketServerDelegate( - ServerHolder* server, - const std::vector& target_ids) + explicit TestSocketServerDelegate(ServerHolder* server, + const std::vector& target_ids) : harness_(server), targets_(target_ids), server_(nullptr),