From abc803a223e43bc53eeab02ecddeb20b6a668135 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 15 Jul 2022 12:52:29 -0400 Subject: [PATCH 1/2] test: add check to test-fs-readfile-tostring-fail Check that all of the bytes were written to the temporary file before reading it to catch the case where there is insufficient disk space. --- test/pummel/test-fs-readfile-tostring-fail.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/pummel/test-fs-readfile-tostring-fail.js b/test/pummel/test-fs-readfile-tostring-fail.js index 1a1e7d62175638..4911d7a032a9a0 100644 --- a/test/pummel/test-fs-readfile-tostring-fail.js +++ b/test/pummel/test-fs-readfile-tostring-fail.js @@ -25,13 +25,17 @@ stream.on('error', (err) => { throw err; }); const size = kStringMaxLength / 200; const a = Buffer.alloc(size, 'a'); +let expectedSize = 0; for (let i = 0; i < 201; i++) { - stream.write(a); + stream.write(a, (err) => { if (err) throw err; }); + expectedSize += a.length; } stream.end(); stream.on('finish', common.mustCall(function() { + assert.strictEqual(stream.bytesWritten, expectedSize, + `${stream.bytesWritten} bytes written (expected ${expectedSize} bytes).`); fs.readFile(file, 'utf8', common.mustCall(function(err, buf) { assert.ok(err instanceof Error); if (err.message !== 'Array buffer allocation failed') { From 1214cea8cc00a174533fb2e50ed46b7bc86b02a4 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 15 Jul 2022 13:09:02 -0400 Subject: [PATCH 2/2] fixup! test: add check to test-fs-readfile-tostring-fail --- test/pummel/test-fs-readfile-tostring-fail.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/pummel/test-fs-readfile-tostring-fail.js b/test/pummel/test-fs-readfile-tostring-fail.js index 4911d7a032a9a0..eb12ed3d8c5cc0 100644 --- a/test/pummel/test-fs-readfile-tostring-fail.js +++ b/test/pummel/test-fs-readfile-tostring-fail.js @@ -28,7 +28,7 @@ const a = Buffer.alloc(size, 'a'); let expectedSize = 0; for (let i = 0; i < 201; i++) { - stream.write(a, (err) => { if (err) throw err; }); + stream.write(a, (err) => { assert.ifError(err); }); expectedSize += a.length; }