From e50db6874dda57c742ffb490f885e377007376ad Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Wed, 8 May 2024 15:02:43 -0300 Subject: [PATCH 1/3] doc: mention push.followTags config This has happened in v20.13.0 release. Adding this doc to prevent edge cases where the releaser will sign and push but won't be able to promote the release. --- doc/contributing/releases.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index e07c529fcbb962..240c8fdabdb967 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -710,6 +710,8 @@ Install `git-secure-tag` npm module: npm install -g git-secure-tag ``` +> Ensure to disable `--follow-tags` in your git settings using: `git config push.followTags false` + Create a tag using the following command: ```bash From a636af1357b6e94b4dbca903fc25409c713e3eeb Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Wed, 8 May 2024 15:05:58 -0300 Subject: [PATCH 2/3] doc: mention GPG=$(TTY) when signing tag --- doc/contributing/releases.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 240c8fdabdb967..d84139513ea700 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -712,7 +712,15 @@ npm install -g git-secure-tag > Ensure to disable `--follow-tags` in your git settings using: `git config push.followTags false` -Create a tag using the following command: +If your GPG key is protected by a password, you might need to run: + +```console +$ export GPG_TTY=$(tty) +``` + +before creating the tag. + +To create a tag use the following command: ```bash git secure-tag -sm "YYYY-MM-DD Node.js vx.y.z () Release" From a3925d9d3bedb4bbd05268fc9e8c8b2743e2bda0 Mon Sep 17 00:00:00 2001 From: Rafael Gonzaga Date: Sun, 12 May 2024 13:06:49 -0300 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Antoine du Hamel --- doc/contributing/releases.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index d84139513ea700..cc07a87a75c8a3 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -712,10 +712,10 @@ npm install -g git-secure-tag > Ensure to disable `--follow-tags` in your git settings using: `git config push.followTags false` -If your GPG key is protected by a password, you might need to run: +If your private key is protected by a passphrase, you might need to run: -```console -$ export GPG_TTY=$(tty) +```bash +export GPG_TTY=$(tty) ``` before creating the tag.