From 217dced9f27636d2ea304ca959651b37d1aac0ad Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Thu, 3 Oct 2024 14:34:16 -0300 Subject: [PATCH 1/2] benchmark: adjust config for deepEqual object This should make easier to read on benchmark/compare and when generating graphs --- benchmark/assert/deepequal-object.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/benchmark/assert/deepequal-object.js b/benchmark/assert/deepequal-object.js index 4238129b292b45..4aa0460c19cacc 100644 --- a/benchmark/assert/deepequal-object.js +++ b/benchmark/assert/deepequal-object.js @@ -4,10 +4,9 @@ const common = require('../common.js'); const assert = require('assert'); const bench = common.createBenchmark(main, { - n: [25, 2e2, 2e3], - size: [1e2, 1e3, 1e4], - strict: [1], - method: ['deepEqual', 'notDeepEqual'], + n: [25, 2e2 ], + size: [1e2, 1e4], + method: ['deepEqual', 'notDeepEqual', 'deepStrictEqual', 'notDeepStrictEqual'], }, { combinationFilter: (p) => { return p.size === 1e4 && p.n === 25 || @@ -30,10 +29,7 @@ function createObj(size, add = '') { })); } -function main({ size, n, method, strict }) { - if (strict) { - method = method.replace('eep', 'eepStrict'); - } +function main({ size, n, method }) { const fn = assert[method]; const actual = createObj(size); From 936e7140b1219bd54ad41877bd27225e9d5825fc Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Mon, 7 Oct 2024 13:59:13 -0300 Subject: [PATCH 2/2] fixup! benchmark: adjust config for deepEqual object --- benchmark/assert/deepequal-object.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmark/assert/deepequal-object.js b/benchmark/assert/deepequal-object.js index 4aa0460c19cacc..c480faf10cbae8 100644 --- a/benchmark/assert/deepequal-object.js +++ b/benchmark/assert/deepequal-object.js @@ -4,7 +4,7 @@ const common = require('../common.js'); const assert = require('assert'); const bench = common.createBenchmark(main, { - n: [25, 2e2 ], + n: [25, 2e2], size: [1e2, 1e4], method: ['deepEqual', 'notDeepEqual', 'deepStrictEqual', 'notDeepStrictEqual'], }, {