From 1277397b2c827e7e424e2b5e51a7da8c80490b00 Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Tue, 4 Mar 2025 09:54:54 -0300 Subject: [PATCH 1/3] doc: prefer to sign commits under nodejs repository --- onboarding.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/onboarding.md b/onboarding.md index bdd266eb52799b..217a2e076d385b 100644 --- a/onboarding.md +++ b/onboarding.md @@ -34,6 +34,8 @@ onboarding session. * git: * Make sure you have whitespace=fix: `git config --global --add apply.whitespace fix` + * It's recommended to default sign commits under the Node.js repository. + Run: `git config commit.gpgsign true` inside nodejs folder. * Always create a branch in your own GitHub fork for pull requests * Branches in the `nodejs/node` repository are only for release lines * Add the canonical nodejs repository as `upstream` remote: From c54e9e6983fc6685295d69771b43b98a6137fd5e Mon Sep 17 00:00:00 2001 From: Rafael Gonzaga Date: Tue, 4 Mar 2025 10:33:38 -0300 Subject: [PATCH 2/3] Update onboarding.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Tobias Nießen --- onboarding.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/onboarding.md b/onboarding.md index 217a2e076d385b..eb0c31dbb069f2 100644 --- a/onboarding.md +++ b/onboarding.md @@ -34,8 +34,8 @@ onboarding session. * git: * Make sure you have whitespace=fix: `git config --global --add apply.whitespace fix` - * It's recommended to default sign commits under the Node.js repository. - Run: `git config commit.gpgsign true` inside nodejs folder. + * It is recommended to sign all commits under the Node.js repository. + Run: `git config commit.gpgsign true` inside the `node` folder. * Always create a branch in your own GitHub fork for pull requests * Branches in the `nodejs/node` repository are only for release lines * Add the canonical nodejs repository as `upstream` remote: From f0787fde2f6a89ff8c12d521c7b2fcd804a81325 Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Tue, 11 Mar 2025 15:20:13 -0300 Subject: [PATCH 3/3] fixup! doc: prefer to sign commits under nodejs repository --- doc/contributing/releases.md | 3 +++ onboarding.md | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 5b6d2180515565..de56e5acd17c12 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -111,6 +111,9 @@ The key you use may be a child/subkey of an existing key. Additionally, full GPG key fingerprints for individuals authorized to release should be listed in the Node.js GitHub README.md file. +> It is recommended to sign all commits under the Node.js repository. +> Run: `git config commit.gpgsign true` inside the `node` folder. + ## How to create a release Notes: diff --git a/onboarding.md b/onboarding.md index eb0c31dbb069f2..bdd266eb52799b 100644 --- a/onboarding.md +++ b/onboarding.md @@ -34,8 +34,6 @@ onboarding session. * git: * Make sure you have whitespace=fix: `git config --global --add apply.whitespace fix` - * It is recommended to sign all commits under the Node.js repository. - Run: `git config commit.gpgsign true` inside the `node` folder. * Always create a branch in your own GitHub fork for pull requests * Branches in the `nodejs/node` repository are only for release lines * Add the canonical nodejs repository as `upstream` remote: