From 629ce17e54ba8385f3d0195f545d3a8ff6ec6689 Mon Sep 17 00:00:00 2001 From: Sakthipriyan Vairamani Date: Fri, 6 May 2016 11:45:00 +0530 Subject: [PATCH 1/2] test: make sure O_NOATIME is present only in Linux As it is, the test checks if the return value is `undefined` in other platforms. But it should also make sure that the `O_NOATIME` should be found only in Linux. --- test/parallel/test-process-constants-noatime.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/test/parallel/test-process-constants-noatime.js b/test/parallel/test-process-constants-noatime.js index cf6b98f794157b..b23dd7c9f74592 100644 --- a/test/parallel/test-process-constants-noatime.js +++ b/test/parallel/test-process-constants-noatime.js @@ -2,10 +2,11 @@ require('../common'); const assert = require('assert'); - -const isLinux = process.platform === 'linux'; - -const O_NOATIME = process.binding('constants').O_NOATIME; -const expected = isLinux ? 0x40000 : undefined; - -assert.strictEqual(O_NOATIME, expected); +const constants = process.binding('constants'); + +if (process.platform === 'linux') { + assert(constants.hasOwnProperty('O_NOATIME')); + assert.strictEqual(constants.O_NOATIME, 0x40000); +} else { + assert(false === constants.hasOwnProperty('O_NOATIME')); +} From fcfb5effa88fa4da04764b7de36f1aa1156560da Mon Sep 17 00:00:00 2001 From: Sakthipriyan Vairamani Date: Fri, 6 May 2016 15:36:04 +0530 Subject: [PATCH 2/2] change the property existence check --- test/parallel/test-process-constants-noatime.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-process-constants-noatime.js b/test/parallel/test-process-constants-noatime.js index b23dd7c9f74592..0503e67c38d6e8 100644 --- a/test/parallel/test-process-constants-noatime.js +++ b/test/parallel/test-process-constants-noatime.js @@ -5,8 +5,8 @@ const assert = require('assert'); const constants = process.binding('constants'); if (process.platform === 'linux') { - assert(constants.hasOwnProperty('O_NOATIME')); + assert('O_NOATIME' in constants); assert.strictEqual(constants.O_NOATIME, 0x40000); } else { - assert(false === constants.hasOwnProperty('O_NOATIME')); + assert(!('O_NOATIME' in constants)); }