From 0bc61b140f554fd631e5d37d3a8cde82ef75cddf Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Thu, 30 Jun 2016 11:23:24 -0700 Subject: [PATCH] test: revert fix test-net-* error code check This reverts commit 0414d882ce425678fed879e07c5c5a98b8ef025d. This is a super weird one. This commit landed with no problems with the test suite. CI tested absolutely fine multiple times. As of June 30 2016 the test suite is now reliably failing on `test-net-*`. This is extremely odd to be coming up after the release and multiple test runs. Weirdness aside, the revert brings the test suite back to a reliable state. This may cause problems for testing on Alpine, this will need to be revisited. --- test/parallel/test-net-better-error-messages-port-hostname.js | 4 ++-- test/parallel/test-net-connect-immediate-finish.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-net-better-error-messages-port-hostname.js b/test/parallel/test-net-better-error-messages-port-hostname.js index 23089baf448a39..9db6fb26f57285 100644 --- a/test/parallel/test-net-better-error-messages-port-hostname.js +++ b/test/parallel/test-net-better-error-messages-port-hostname.js @@ -3,12 +3,12 @@ var common = require('../common'); var net = require('net'); var assert = require('assert'); -var c = net.createConnection(common.PORT, '***'); +var c = net.createConnection(common.PORT, '...'); c.on('connect', common.fail); c.on('error', common.mustCall(function(e) { assert.equal(e.code, 'ENOTFOUND'); assert.equal(e.port, common.PORT); - assert.equal(e.hostname, '***'); + assert.equal(e.hostname, '...'); })); diff --git a/test/parallel/test-net-connect-immediate-finish.js b/test/parallel/test-net-connect-immediate-finish.js index 6114233677f5cb..a5403732ec1d0d 100644 --- a/test/parallel/test-net-connect-immediate-finish.js +++ b/test/parallel/test-net-connect-immediate-finish.js @@ -3,14 +3,14 @@ const common = require('../common'); const assert = require('assert'); const net = require('net'); -const client = net.connect({host: '***', port: common.PORT}); +const client = net.connect({host: '...', port: common.PORT}); client.once('error', common.mustCall(function(err) { assert(err); assert.strictEqual(err.code, err.errno); assert.strictEqual(err.code, 'ENOTFOUND'); assert.strictEqual(err.host, err.hostname); - assert.strictEqual(err.host, '***'); + assert.strictEqual(err.host, '...'); assert.strictEqual(err.syscall, 'getaddrinfo'); }));