Skip to content

Commit de5f7ef

Browse files
sonicdoefhemberger
authored andcommitted
Use Node.js version number instead of codename in Docker guide (#1700)
The use of Node.js’s release codenames isn’t very widespread and, if I had to guess, not a lot of people are aware that Node.js v8 is codenamed Carbon. Therefore, I’d argue that using the actual version number in the Docker guide would reduce confusion and make it more obvious which Node.js version is being used.
1 parent 1d9dd3a commit de5f7ef

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

locale/en/docs/guides/nodejs-docker-webapp.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,11 @@ touch Dockerfile
8282
Open the `Dockerfile` in your favorite text editor
8383

8484
The first thing we need to do is define from what image we want to build from.
85-
Here we will use the latest LTS (long term support) version `carbon` of `node`
85+
Here we will use the latest LTS (long term support) version `8` of `node`
8686
available from the [Docker Hub](https://hub.docker.com/):
8787

8888
```docker
89-
FROM node:carbon
89+
FROM node:8
9090
```
9191

9292
Next we create a directory to hold the application code inside the image, this
@@ -144,7 +144,7 @@ CMD [ "npm", "start" ]
144144
Your `Dockerfile` should now look like this:
145145

146146
```docker
147-
FROM node:carbon
147+
FROM node:8
148148
149149
# Create app directory
150150
WORKDIR /usr/src/app
@@ -195,7 +195,7 @@ $ docker images
195195

196196
# Example
197197
REPOSITORY TAG ID CREATED
198-
node carbon 1934b0b038d1 5 days ago
198+
node 8 1934b0b038d1 5 days ago
199199
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
200200
```
201201

locale/ko/docs/guides/nodejs-docker-webapp.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,11 @@ touch Dockerfile
147147
Open the `Dockerfile` in your favorite text editor
148148
149149
The first thing we need to do is define from what image we want to build from.
150-
Here we will use the latest LTS (long term support) version `carbon` of `node`
150+
Here we will use the latest LTS (long term support) version `8` of `node`
151151
available from the [Docker Hub](https://hub.docker.com/):
152152
153153
```docker
154-
FROM node:carbon
154+
FROM node:8
155155
```
156156
-->
157157

@@ -167,10 +167,10 @@ touch Dockerfile
167167

168168
가장 먼저 해야 할 것은 어떤 이미지를 사용해서 빌드할 것인지를 정의하는 것입니다. 여기서는
169169
[Docker Hub](https://hub.docker.com/)에 있는
170-
`node`의 최신 LTS(장기 지원) 버전인 `carbon`을 사용할 것입니다.
170+
`node`의 최신 LTS(장기 지원) 버전인 `8`을 사용할 것입니다.
171171

172172
```docker
173-
FROM node:carbon
173+
FROM node:8
174174
```
175175

176176
<!--
@@ -264,7 +264,7 @@ CMD [ "npm", "start" ]
264264
Your `Dockerfile` should now look like this:
265265
266266
```docker
267-
FROM node:carbon
267+
FROM node:8
268268
269269
# Create app directory
270270
WORKDIR /usr/src/app
@@ -296,7 +296,7 @@ CMD [ "npm", "start" ]
296296
`Dockerfile`은 다음과 같아야 합니다.
297297

298298
```docker
299-
FROM node:carbon
299+
FROM node:8
300300
301301
# 앱 디렉터리 생성
302302
WORKDIR /usr/src/app
@@ -357,7 +357,7 @@ $ docker images
357357
358358
# Example
359359
REPOSITORY TAG ID CREATED
360-
node carbon 1934b0b038d1 5 days ago
360+
node 8 1934b0b038d1 5 days ago
361361
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
362362
```
363363
-->
@@ -379,7 +379,7 @@ $ docker images
379379

380380
# 예시
381381
REPOSITORY TAG ID CREATED
382-
node carbon 1934b0b038d1 5 days ago
382+
node 8 1934b0b038d1 5 days ago
383383
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
384384
```
385385

locale/uk/docs/guides/nodejs-docker-webapp.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,11 @@ touch Dockerfile
8282
Open the `Dockerfile` in your favorite text editor
8383

8484
The first thing we need to do is define from what image we want to build from.
85-
Here we will use the latest LTS (long term support) version `carbon` of `node`
85+
Here we will use the latest LTS (long term support) version `8` of `node`
8686
available from the [Docker Hub](https://hub.docker.com/):
8787

8888
```docker
89-
FROM node:carbon
89+
FROM node:8
9090
```
9191

9292
Next we create a directory to hold the application code inside the image, this
@@ -144,7 +144,7 @@ CMD [ "npm", "start" ]
144144
Your `Dockerfile` should now look like this:
145145

146146
```docker
147-
FROM node:carbon
147+
FROM node:8
148148
149149
# Create app directory
150150
WORKDIR /usr/src/app
@@ -195,7 +195,7 @@ $ docker images
195195

196196
# Example
197197
REPOSITORY TAG ID CREATED
198-
node carbon 1934b0b038d1 5 days ago
198+
node 8 1934b0b038d1 5 days ago
199199
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
200200
```
201201

0 commit comments

Comments
 (0)