Skip to content

Commit f945bb5

Browse files
authored
remove CPUSET due to a it not working as we see a lot of NaN in the results (#161)
1 parent a008e84 commit f945bb5

File tree

1 file changed

+1
-6
lines changed
  • benchmarks/community-benchmark

1 file changed

+1
-6
lines changed

benchmarks/community-benchmark/run.sh

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ echo "The following are optional across both use cases"
3838
echo "RUNS = defaults to empty"
3939
echo "FILTER = defaults to empty"
4040
echo "MACHINE_THREADS - used for building node. Defaults to all threads on machine"
41-
echo "CPUSET - used for pinning to specific CPU cores. Default to 0-11 (performance cores)"
4241
}
4342

4443
if [ -z $PULL_ID ]; then
@@ -54,7 +53,6 @@ fi
5453
mandatory CATEGORY
5554
optional RUNS
5655
optional FILTER
57-
optional CPUSET "0-11"
5856
getMACHINE_THREADS=`cat /proc/cpuinfo |grep processor|tail -n1|awk {'print $3'}`
5957
let getMACHINE_THREADS=getMACHINE_THREADS+1 #getting threads this way is 0 based. Add one
6058
optional MACHINE_THREADS $getMACHINE_THREADS
@@ -98,14 +96,11 @@ fi
9896
if [ -n "$RUNS" ]; then
9997
RUNS="--runs ${RUNS}"
10098
fi
101-
if [ -n "$CPUSET" ]; then
102-
CPUSET="--set CPUSET=${CPUSET}"
103-
fi
10499
# run benchmark
105100
fileName=output`date +%d%m%y-%H%M%S`.csv
106101
echo "Output will be saved to $fileName"
107102
pwd
108-
./node-master benchmark/compare.js $CPUSET --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName
103+
./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName
109104

110105
cat $fileName | Rscript benchmark/compare.R
111106
mv $fileName $startDir

0 commit comments

Comments
 (0)