From 2f83e2b99138c62ee03147333d24d7bac52d54cc Mon Sep 17 00:00:00 2001 From: Ulises Gascon Date: Mon, 29 May 2023 19:47:30 +0200 Subject: [PATCH 1/7] doc: add meeting notes 2023-05-29 Signed-off-by: Ulises Gascon --------- Co-authored-by: Yagiz Nizipli --- meetings/2023-05-29.md | 60 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 meetings/2023-05-29.md diff --git a/meetings/2023-05-29.md b/meetings/2023-05-29.md new file mode 100644 index 0000000..435e559 --- /dev/null +++ b/meetings/2023-05-29.md @@ -0,0 +1,60 @@ +# Node.js Performance Team Meeting 2023-05-29 + +## Links + +* **Recording**: https://www.youtube.com/watch?v=bqjXEyPQSfs +* **GitHub Issue**: https://github.com/nodejs/performance/issues/85 + +## Present + +* Performance team: @nodejs/performance +* Ulises Gascon: @ulisesgascon +* Robert Nagy: @ronag +* Vinícius Lourenço: @H4ad +* Yagiz Nizipli: @anonrig + +## Agenda + +## Announcements + +*Extracted from **performance-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. + + +* https://github.com/nodejs/node/pull/48078 + * It is providing a performance boost due the new Linux architecture + +* https://github.com/nodejs/performance/issues/85#issuecomment-1563757752 + * 30% boost at startup (v20.1.0 -> v20.2.0) + +* Ulises will help to host the next two meetings + +### nodejs/performance + +* Performance of WHATWG ReadableStream.read() [#82](https://github.com/nodejs/performance/issues/82) + * We are a little bit slower in comparison with Bun and Deno + * It will be nice to see if Deno/Bun is using native implementation or JS. +* Improve legacy CJS resolve #73 + * The current approach is to use `simdjson` to perform the JSON parsing and increase the performance. See: https://github.com/nodejs/node/pull/47991 + * @H4ad is working on this issue from now on +* MakeCallback is very slow [#24](https://github.com/nodejs/performance/issues/24) + * We reached out to more people about it, including the TSC meeting. + * We need to do a deeper investigation + * This approach made by the `uWebSockets.js` is interesting. See: https://github.com/nodejs/performance/issues/24#issuecomment-1559993286 + * Daniel & Yagiz will work soon in a new library to resolve the Websockets layer (compatible with Node.js) + +* fetch [#11](https://github.com/nodejs/performance/issues/11) + * No news, we will remove it from the agenda + * Benchmarks and more info is needed before we can make any progress. + * Contributions from the community are more than welcome here. + +## Q&A, Other + +* Expensive `isTraceHTTPEnable` (https://github.com/nodejs/performance/issues/81) will be added back to the agenda. +* Vinícius will be nominated as Performance Team member + +## Upcoming Meetings + +* **Node.js Foundation Calendar**: https://nodejs.org/calendar + +Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. + From 8aa6197eb13b7e16bf2903bb9f65f5d84a34506a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Mon, 29 May 2023 21:17:26 +0200 Subject: [PATCH 2/7] Update meetings/2023-05-29.md Co-authored-by: Yagiz Nizipli --- meetings/2023-05-29.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meetings/2023-05-29.md b/meetings/2023-05-29.md index 435e559..5d4e9b3 100644 --- a/meetings/2023-05-29.md +++ b/meetings/2023-05-29.md @@ -20,7 +20,8 @@ *Extracted from **performance-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. -* https://github.com/nodejs/node/pull/48078 +* Libuv 1.45.0: https://github.com/nodejs/node/pull/48078 + * Thanks to @bnoordhuis and https://github.com/isc-projects which iiuc sponsored some of his work. * It is providing a performance boost due the new Linux architecture * https://github.com/nodejs/performance/issues/85#issuecomment-1563757752 From 9aca43d2bf23dce4bf8e3d85d44e566b6d31aabd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Mon, 29 May 2023 21:17:44 +0200 Subject: [PATCH 3/7] Update meetings/2023-05-29.md Co-authored-by: Yagiz Nizipli --- meetings/2023-05-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2023-05-29.md b/meetings/2023-05-29.md index 5d4e9b3..93546c6 100644 --- a/meetings/2023-05-29.md +++ b/meetings/2023-05-29.md @@ -27,7 +27,7 @@ * https://github.com/nodejs/performance/issues/85#issuecomment-1563757752 * 30% boost at startup (v20.1.0 -> v20.2.0) -* Ulises will help to host the next two meetings +* Yagiz is leaving for paternity leave. Ulises will help to host the next two meetings. ### nodejs/performance From 1233fce2f3848e91ab55256ff35b288b7fbd6add Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Mon, 29 May 2023 21:17:51 +0200 Subject: [PATCH 4/7] Update meetings/2023-05-29.md Co-authored-by: Yagiz Nizipli --- meetings/2023-05-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2023-05-29.md b/meetings/2023-05-29.md index 93546c6..98f8a47 100644 --- a/meetings/2023-05-29.md +++ b/meetings/2023-05-29.md @@ -41,7 +41,7 @@ * We reached out to more people about it, including the TSC meeting. * We need to do a deeper investigation * This approach made by the `uWebSockets.js` is interesting. See: https://github.com/nodejs/performance/issues/24#issuecomment-1559993286 - * Daniel & Yagiz will work soon in a new library to resolve the Websockets layer (compatible with Node.js) + * Daniel(@lemire) & Yagiz will work soon in a new library to resolve the Websockets layer (compatible with Node.js) * fetch [#11](https://github.com/nodejs/performance/issues/11) * No news, we will remove it from the agenda From ea615792d4421b3743afc45b83bd643f3d55d0ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Mon, 29 May 2023 21:17:56 +0200 Subject: [PATCH 5/7] Update meetings/2023-05-29.md Co-authored-by: Yagiz Nizipli --- meetings/2023-05-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2023-05-29.md b/meetings/2023-05-29.md index 98f8a47..a32ec13 100644 --- a/meetings/2023-05-29.md +++ b/meetings/2023-05-29.md @@ -25,7 +25,7 @@ * It is providing a performance boost due the new Linux architecture * https://github.com/nodejs/performance/issues/85#issuecomment-1563757752 - * 30% boost at startup (v20.1.0 -> v20.2.0) + * Thanks to @kvakil: 30% boost at startup (v20.1.0 -> v20.2.0) * Yagiz is leaving for paternity leave. Ulises will help to host the next two meetings. From b63ca636ee52bc27a4b55914883d0c1376661559 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Mon, 29 May 2023 21:18:02 +0200 Subject: [PATCH 6/7] Update meetings/2023-05-29.md Co-authored-by: Yagiz Nizipli --- meetings/2023-05-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2023-05-29.md b/meetings/2023-05-29.md index a32ec13..583b090 100644 --- a/meetings/2023-05-29.md +++ b/meetings/2023-05-29.md @@ -51,7 +51,7 @@ ## Q&A, Other * Expensive `isTraceHTTPEnable` (https://github.com/nodejs/performance/issues/81) will be added back to the agenda. -* Vinícius will be nominated as Performance Team member +* Vinícius is nominated/invited to the Performance Team. Reference: https://github.com/nodejs/performance/issues/86 ## Upcoming Meetings From abaab64130235cc819fcb83290ad839d9e54b541 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Mon, 29 May 2023 21:18:07 +0200 Subject: [PATCH 7/7] Update meetings/2023-05-29.md Co-authored-by: Yagiz Nizipli --- meetings/2023-05-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2023-05-29.md b/meetings/2023-05-29.md index 583b090..3d4daf7 100644 --- a/meetings/2023-05-29.md +++ b/meetings/2023-05-29.md @@ -50,7 +50,7 @@ ## Q&A, Other -* Expensive `isTraceHTTPEnable` (https://github.com/nodejs/performance/issues/81) will be added back to the agenda. +* Expensive `isTraceHTTPEnable` (https://github.com/nodejs/performance/issues/81) is worth mentioning. @H4ad is working on it. * Vinícius is nominated/invited to the Performance Team. Reference: https://github.com/nodejs/performance/issues/86 ## Upcoming Meetings