rewrite autocomplete

Author: devsnek

src/io.js

@@ -263,7 +263,9 @@ class IO {
           await this.autocomplete();
         }
       } catch {} // eslint-disable-line no-empty
+      return;
     }
+    await this.flip();
   }
 
   async setPrefix(s = '') {

src/repl.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const util = require('util');
-const acorn = require('acorn');
+const { parse_dammit: parseDammit } = require('acorn/dist/acorn_loose');
 const IO = require('./io');
 const highlight = require('./highlight');
 const { processTopLevelAwait } = require('./await');
@@ -47,14 +47,6 @@ function wrapObjectLiteralExpressionIfNeeded(code) {
   }
 }
 
-function isCallExpression(code) {
-  try {
-    return acorn.parse(code).body[0].expression.type === 'CallExpression';
-  } catch {
-    return false;
-  }
-}
-
 async function collectGlobalNames() {
   const keys = Object.getOwnPropertyNames(global);
   try {
@@ -170,115 +162,98 @@ Prototype REPL - https://github.com/nodejs/repl`,
   }
 
   async onAutocomplete(buffer) {
+    if (buffer.length === 0) {
+      return collectGlobalNames();
+    }
+
+    const statement = parseDammit(buffer).body[0];
+    if (statement.type !== 'ExpressionStatement') {
+      return undefined;
+    }
+    const { expression } = statement;
+
     let keys;
     let filter;
-    if (buffer.length === 0) {
+    if (expression.type === 'Identifier') {
       keys = await collectGlobalNames();
-    } else {
-      let expr;
-      let computed = false;
-      let leadingQuote = false;
+      filter = expression.name;
+    }
 
-      let index = buffer.lastIndexOf('.');
-      if (index !== -1) {
-        expr = buffer.slice(0, index);
-        filter = buffer.slice(index + 1, buffer.length).trim();
+    if (expression.type === 'MemberExpression') {
+      const expr = buffer.slice(expression.object.start, expression.object.end);
+      let leadingQuote = false;
+      if (expression.computed && expression.property.type === 'Literal') {
+        filter = expression.property.value;
+        leadingQuote = expression.property.raw.startsWith('\'');
+      } else if (!expression.computed && expression.property.type === 'Identifier') {
+        filter = expression.property.name === '✖' ? undefined : expression.property.name;
       }
 
-      if (!expr) {
-        index = buffer.lastIndexOf('[\'');
-        if (index !== -1) {
-          expr = buffer.slice(0, index);
-          filter = buffer.slice(index + 2, buffer.length);
-          computed = true;
-          leadingQuote = true;
-        }
+      const evaluateResult = await this.eval(expr, false, true);
+      if (evaluateResult.exceptionDetails) {
+        return undefined;
       }
 
-      if (!expr) {
-        index = buffer.lastIndexOf('[');
-        if (index !== -1) {
-          expr = buffer.slice(0, index);
-          filter = buffer.slice(index + 1, buffer.length);
-          computed = true;
-        }
-      }
+      const own = [];
+      const inherited = [];
+      (await Runtime.getProperties({
+        objectId: evaluateResult.result.objectId,
+        generatePreview: true,
+      }))
+        .result
+        .filter(({ symbol }) => !symbol)
+        .forEach(({ isOwn, name }) => {
+          if (isOwn) {
+            own.push(name);
+          } else {
+            inherited.push(name);
+          }
+        });
 
-      if (isCallExpression(filter)) {
-        expr = undefined;
-        filter = undefined;
-      }
+      keys = [...own, ...inherited];
 
-      if (expr) {
-        const evaluateResult = await this.eval(expr, false, true);
-        if (evaluateResult.exceptionDetails) {
+      if (keys.includes(filter)) {
+        const { result, exceptionDetails } =
+          await this.eval(wrapObjectLiteralExpressionIfNeeded(buffer), false, true);
+        if (exceptionDetails) {
           return undefined;
         }
+        return ` // ${await oneLineInspect(result)}`;
+      }
 
-        const own = [];
-        const inherited = [];
-
-        (await Runtime.getProperties({
-          objectId: evaluateResult.result.objectId,
-          generatePreview: true,
-        }))
-          .result
-          .filter(({ symbol }) => !symbol)
-          .forEach(({ isOwn, name }) => {
-            if (isOwn) {
-              own.push(name);
-            } else {
-              inherited.push(name);
-            }
-          });
-        const k = [...own, ...inherited];
-
-        if (computed) {
-          keys = k.map((key) => {
-            let r;
-            if (!leadingQuote && `${+key}` === key) {
-              r = `${key}]`;
-            } else {
-              r = `${strEscape(key)}]`;
-            }
+      if (expression.computed) {
+        keys = keys.map((key) => {
+          let r;
+          if (!leadingQuote && `${+key}` === key) {
+            r = key;
+          } else {
+            r = strEscape(key);
             if (leadingQuote) {
-              return r.slice(1);
+              r = r.slice(1);
             }
-            return r;
-          });
-        } else {
-          keys = k.filter(isIdentifier);
-        }
+          }
+          return `${r}]`;
+        });
       } else {
-        const evaluateResult = await this.eval(
-          wrapObjectLiteralExpressionIfNeeded(buffer), false, true,
-        );
-        if (evaluateResult.exceptionDetails) {
-          return undefined;
-        }
-        return ` // ${await oneLineInspect(evaluateResult.result)}`;
+        keys = keys.filter(isIdentifier);
       }
     }
 
     if (keys) {
       if (filter) {
-        if (keys.includes(filter)) {
-          const evaluateResult = await this.eval(
-            wrapObjectLiteralExpressionIfNeeded(buffer), false, true,
-          );
-          if (evaluateResult.exceptionDetails) {
-            return undefined;
-          }
-          return ` // ${await oneLineInspect(evaluateResult.result)}`;
-        }
-
         return keys
           .filter((k) => k.startsWith(filter))
           .map((k) => k.slice(filter.length));
       }
       return keys;
     }
-    return undefined;
+
+    const { result, exceptionDetails } =
+      await this.eval(wrapObjectLiteralExpressionIfNeeded(buffer), false, true);
+    if (exceptionDetails) {
+      return undefined;
+    }
+    return ` // ${await oneLineInspect(result)}`;
   }
 }