Avoid cycles in failedDependency

failedDependency is depth first search for a path to a top-level or user-required package.
If failedDependency revisits a package it will recurse till it blows the call stack.

Author: everett1992

lib/install/deps.js

@@ -436,7 +436,11 @@ function isDepOptional (tree, name, pkg) {
 }
 
 exports.failedDependency = failedDependency
-function failedDependency (tree, name, pkg) {
+function failedDependency (tree, name, pkg, visited = new Set()) {
+  // cycle detection
+  if (visited.has(tree)) return false
+  visited.add(tree)
+
   if (name) {
     if (isDepOptional(tree, name, pkg || {})) {
       return false
@@ -454,7 +458,7 @@ function failedDependency (tree, name, pkg) {
   let anyFailed = false
   for (var ii = 0; ii < tree.requiredBy.length; ++ii) {
     var requireParent = tree.requiredBy[ii]
-    if (failedDependency(requireParent, moduleName(tree), tree)) {
+    if (failedDependency(requireParent, moduleName(tree), tree, visited)) {
       anyFailed = true
     }
   }