chore(exit): log any un-ended timings #3479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/stale-timings
branch
from
ca14bc2 to
bc30695
Compare
darcyclarke
added
the
Release 7.x
ruyadorno
approved these changes
Jul 12, 2021
ruyadorno
added
release: next
It will be helpful to us when debugging the "exit handler never called" bugs to know which timings were started but not ended. Tests moved to use real npm. PR-URL: #3479 Credit: @wraithgar Close: #3479 Reviewed-by: @ruyadorno
wraithgar
force-pushed
the
gar/stale-timings
branch
from
bc30695 to
103c8c3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be helpful to us when debugging the "exit handler never called"
bugs to know which timings were started but not ended.
Tests moved to use real npm.