Skip to content
This repository was archived by the owner on Nov 16, 2019. It is now read-only.

npmignore entries trump files entries #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Apr 1, 2016

Previously, files were treated as negated-negated ignores. This made it fairly
tricky to control whether files or .npmignore took priority when deciding whether
a file should be included.

With this change, files are included through a more explicit process, and
any applicable ignores will trump specific files.

Previously, files were treated as negated-negated ignores. This made it fairly
tricky to control whether files or .npmignore took priority when deciding whether
a file should be included.

With this change, files are included through a more explicit process, and
any applicable ignores will trump specific files.
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 81.169% when pulling 7e2d046 on zkat/npmignore-trumps-files into d57b6b2 on master.

@sophistifunk
Copy link

Has this recently been implemented somewhere? Because this fix has (in the last couple of days) started breaking things where we have dist in our files:[] list but also in .gitignore and running npm publish results in modules without any (code) content. Having to maintain duplicate ignore lists (only one without "dist") is an ugly thing to foist on the users IMO.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants