Fix parse-community#494: Reject a promise on error condition

Author: nrchandan

integration/test/ParseObjectTest.js

@@ -254,6 +254,18 @@ describe('Parse Object', () => {
     });
   });
 
+  it('cannot set an invalid date', (done) => {
+    let obj = new TestObject();
+    obj.set('when', new Date(Date.parse(null)));
+    Parse.Object.saveAll([obj]).then(() => {
+      done.fail('Expected invalid date to fail');
+    }).fail((error) => {
+      expect(error[0].code).toEqual(ParseError.INVALID_VALUE);
+      expect(error[0].message).toEqual('Tried to encode an invalid date.');
+      done();
+    });
+  });
+
   it('cannot create invalid class names', (done) => {
     let item = new Parse.Object('Foo^Bar');
     item.save().fail((e) => {

src/ParseError.js

@@ -493,3 +493,11 @@ ParseError.FILE_READ_ERROR = 601;
  * @final
  */
 ParseError.X_DOMAIN_REQUEST = 602;
+
+/**
+ * Error code indicating an invalid value of an object field is passed.
+ * @property INVALID_VALUE
+ * @static
+ * @final
+ */
+ParseError.INVALID_VALUE = 603;

src/ParseObject.js

@@ -1847,6 +1847,8 @@ var DefaultController = {
             }, options);
           }).then((response, status, xhr) => {
             batchReturned.resolve(response, status);
+          }, (error) => {
+            batchReturned.reject(new ParseError(ParseError.INVALID_VALUE, error.message));
           });
 
           return ParsePromise.when(batchTasks);

src/__tests__/ParseObject-test.js

@@ -1115,6 +1115,19 @@ describe('ParseObject', () => {
     });
   });
 
+  it('should fail on invalid date', (done) => {
+    var obj = new ParseObject('Item');
+    obj.set('when', new Date(Date.parse(null)));
+    ParseObject.saveAll([obj]).then(() => {
+      done.fail('Expected invalid date to fail');
+    }).fail((error) => {
+      expect(error[0].code).toEqual(ParseError.INVALID_VALUE);
+      expect(error[0].message).toEqual('Tried to encode an invalid date.');
+      done();
+    });
+    jest.runAllTicks();
+  });
+
   it('can save a ring of objects, given one exists', (done) => {
     var xhrs = [];
     RESTController._setXHR(function() {