Skip to content

V6: Can not get protractor baseUrl to work #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jared-christensen opened this issue May 31, 2018 · 5 comments
Closed

V6: Can not get protractor baseUrl to work #557

jared-christensen opened this issue May 31, 2018 · 5 comments
Labels

Comments

@jared-christensen
Copy link

jared-christensen commented May 31, 2018

@angular /[email protected]
@nrwl /[email protected]

I tried setting baseUrl directly in the potractor.conf.js and also using ng e2e dashboard-e2e --base-url=http://google.com with no luck.

I got an error when trying
npm run affected:e2e -- --base=master --head=HEAD --base-url=https://google.com

Testing dashboard-e2e, forgot-e2e, login-e2e
Schema validation failed with the following errors:
  Data path ".baseUrl" should be string.
/Users/jaredc/Repositories/customer-apps/node_modules/@nrwl/schematics/node_modules/yargs/yargs.js:1101
      else throw err
           ^

Error: Command failed: node /Users/jaredc/Repositories/customer-apps/node_modules/@angular/cli/bin/ng e2e --base-url=https://google.com --baseUrl=https://google.com --project=dashboard-e2e
    at checkExecSyncError (child_process.js:603:11)
    at Object.execSync (child_process.js:640:13)
    at /Users/jaredc/Repositories/customer-apps/node_modules/@nrwl/schematics/src/command-line/affected.js:139:29
    at Array.forEach (<anonymous>)
    at e2e (/Users/jaredc/Repositories/customer-apps/node_modules/@nrwl/schematics/src/command-line/affected.js:138:14)
    at Object.affected (/Users/jaredc/Repositories/customer-apps/node_modules/@nrwl/schematics/src/command-line/affected.js:46:13)
    at Object.handler (/Users/jaredc/Repositories/customer-apps/node_modules/@nrwl/schematics/src/command-line/nx.js:19:145)
    at Object.runCommand (/Users/jaredc/Repositories/customer-apps/node_modules/@nrwl/schematics/node_modules/yargs/lib/command.js:235:44)
    at Object.parseArgs [as _parseArgs] (/Users/jaredc/Repositories/customer-apps/node_modules/@nrwl/schematics/node_modules/yargs/yargs.js:1014:30)
    at Object.get [as argv] (/Users/jaredc/Repositories/customer-apps/node_modules/@nrwl/schematics/node_modules/yargs/yargs.js:957:21)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] affected:e2e: `nx affected:e2e "--base=master" "--head=HEAD" "--base-url=https://dice.com"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] affected:e2e script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/jaredc/.npm/_logs/2018-05-31T19_59_17_612Z-debug.log
@jared-christensen
Copy link
Author

This actually might be a problem with the Angular CLI. I created an issue for them here angular/angular-cli#11089.

I found I can pass base-url like this.
npm run affected:e2e -- --base=master --head=HEAD --baseUrl=https://google.com

@FrozenPandaz
Copy link
Collaborator

npm run affected:e2e -- --base=master --head=HEAD --baseUrl=https://google.com

That does indeed work :)

@jared-christensen
Copy link
Author

@FrozenPandaz Am I dreaming up the issue with the Angular CLI not using the base url I pass it? Was not sure if you just tested the affected:e2e script or if you ran the test and the baseUrl worked.

@FrozenPandaz
Copy link
Collaborator

Ah sorry... You are right, that does not work right now. But theoretically, it should. Can we keep this issue here closed and track progress in angular/angular-cli#11089?

Thank you.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants