Skip to content

Commenting out the first line of CSS inside of an html file is broken #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
s4my opened this issue May 21, 2022 · 3 comments
Closed

Commenting out the first line of CSS inside of an html file is broken #164

s4my opened this issue May 21, 2022 · 3 comments
Labels
wontfix This will not be worked on

Comments

@s4my
Copy link

s4my commented May 21, 2022

Hi @numToStr, in the process of trying to comment out a block of css inside of an html file (inside of <style> tag), the html comment string is used <!-- %s --> instead of the css comment string /* %s */. this bug happens for both linewise and blockwise comments.

<!DOCTYPE html>
<html>
    <head>
        <title>Comment.nvim bug</title>
        <style>
            <!-- body { -->
                background: #f7f7f8;
                font-family: Inter,Roobert,Helvetica Neue,Helvetica,Arial,sans-serif;
            }
        </style>
    </head>
    <body>
</html>

if you start your selection from the second line after the <style> tag the plugin works perfectly.

<!DOCTYPE html>
<html>
    <head>
        <title>Comment.nvim bug</title>
        <style>
            body {
            /*     background: #f7f7f8; */
            /*     font-family: Inter,Roobert,Helvetica Neue,Helvetica,Arial,sans-serif; */
            /* } */
        </style>
    </head>
    <body>
</html>
@numToStr
Copy link
Owner

This is expected and already discussed. #62 (comment)

@s4my
Copy link
Author

s4my commented May 21, 2022

ok, waiting for the fix i guess :)

@numToStr
Copy link
Owner

@s4my To be clear, this is also listed as limitation in the README so I don't think there will be any fix for this issue.

@numToStr numToStr added the wontfix This will not be worked on label May 21, 2022
@numToStr numToStr closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s4my @numToStr