Skip to content

test: add unit tests for core/resolver.js #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2019

Conversation

cuixiaorui
Copy link

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #5790 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5790      +/-   ##
==========================================
+ Coverage   95.64%   95.67%   +0.03%     
==========================================
  Files          82       82              
  Lines        2662     2662              
  Branches      682      682              
==========================================
+ Hits         2546     2547       +1     
+ Misses         98       97       -1     
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.71% <ø> (ø) ⬆️
#unit 92.63% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
packages/core/src/resolver.js 100% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59071e4...733806e. Read the comment docs.

@atinux atinux requested a review from clarkdo May 23, 2019 07:46
@clarkdo clarkdo changed the title feat(core): add unit tests for core/resolver.js test: add unit tests for core/resolver.js May 23, 2019
@clarkdo clarkdo merged commit 6e9cf8e into nuxt:dev May 23, 2019
@clarkdo
Copy link
Member

clarkdo commented May 23, 2019

@cuixiaorui Tips: For tests change, please use test: as the type of pr title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants