-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
refactor(vue-app): simplify mount error log #5826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@manniL For confirmation, dosen't it cause duplicate errors in console? |
Codecov Report
@@ Coverage Diff @@
## dev #5826 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 82 82
Lines 2687 2687
Branches 689 689
=======================================
Hits 2571 2571
Misses 98 98
Partials 18 18
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #5826 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 82 82
Lines 2687 2687
Branches 689 689
=======================================
Hits 2571 2571
Misses 98 98
Partials 18 18
Continue to review full report at Codecov.
|
@pi0 Stacktrace in FF w/o It's easier to trace then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused, because we already log error in default errorHandler, so is it only for less stacktrace? If so, I think we'd better optimize original log format.
The only difference is a error wrapper
, may be we can change the wrapper to prepended message.
Maybe we can just pass the original error to errorHandler. |
In case the mounting of the app fails, the error should be logged to the console in dev mode so it's easier to trace
Types of changes
Checklist: