Skip to content

refactor(vue-app): simplify mount error log #5826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 30, 2019
Merged

Conversation

TheAlexLichter
Copy link
Member

In case the mounting of the app fails, the error should be logged to the console in dev mode so it's easier to trace

Types of changes

  • DX Improvements

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

pi0
pi0 previously approved these changes May 28, 2019
@pi0
Copy link
Member

pi0 commented May 28, 2019

@manniL For confirmation, dosen't it cause duplicate errors in console?

@pi0 pi0 changed the title chore: separately log mount error in dev mode chore(vue-app): separately log mount error in dev mode May 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #5826 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5826   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          82       82           
  Lines        2687     2687           
  Branches      689      689           
=======================================
  Hits         2571     2571           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.42% <ø> (ø) ⬆️
#unit 92.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e161d70...a95f6a1. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #5826 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5826   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          82       82           
  Lines        2687     2687           
  Branches      689      689           
=======================================
  Hits         2571     2571           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.42% <ø> (ø) ⬆️
#unit 92.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d149e9f...3e75558. Read the comment docs.

@TheAlexLichter
Copy link
Member Author

@pi0 Stacktrace in FF w/o

image

With the error logged
image

It's easier to trace then ☺️

@atinux atinux self-requested a review May 29, 2019 09:42
atinux
atinux previously approved these changes May 29, 2019
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused, because we already log error in default errorHandler, so is it only for less stacktrace? If so, I think we'd better optimize original log format.

The only difference is a error wrapper, may be we can change the wrapper to prepended message.

@atinux atinux self-requested a review May 30, 2019 06:49
@pi0 pi0 self-requested a review May 30, 2019 09:42
@pi0
Copy link
Member

pi0 commented May 30, 2019

Maybe we can just pass the original error to errorHandler. [error while mountin] is not so useful for tracing.

@clarkdo clarkdo dismissed stale reviews from atinux and pi0 via 0331002 May 30, 2019 13:24
@clarkdo clarkdo changed the title chore(vue-app): separately log mount error in dev mode refactor(vue-app): simplify log mount error May 30, 2019
@clarkdo clarkdo changed the title refactor(vue-app): simplify log mount error refactor(vue-app): simplify mount error log May 30, 2019
@clarkdo clarkdo merged commit 2e41bb4 into dev May 30, 2019
@clarkdo clarkdo deleted the separately-log-mount-err branch May 30, 2019 13:29
@pi0 pi0 mentioned this pull request May 30, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants