fix(vue-app): fix exception on property access of undefined object #5867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #5867 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 82 82
Lines 2690 2690
Branches 690 690
=======================================
Hits 2574 2574
Misses 98 98
Partials 18 18
Continue to review full report at Codecov.
|
|
@clarkdo please review |
clarkdo
reviewed
Jun 4, 2019
There was a problem hiding this comment.
@rchl Good catch.
The checking is necessary, but I suggest returning first if matchedRoute is undefined.
const [matchedRoute] = this.$route.matched
if (!matchedRoute) {
return this.$route.path
}
const Component = matchedRoute && matchedRoute.components.default
// ...
After PR #5746, which has added code to remove trailing slash in non-strict mode, I've gotten exception reported through Sentry due to trying to get proper 'path' of undefined 'matchedRoute' object. I don't know how it happens but it's clear error as code above checks for null `matchedRoute` but not the code that checks for trailing slash. Made the logic so that non-replaced path is returned when no route matches. Same as before original fix.
clarkdo
approved these changes
Jun 4, 2019
Merged
|
@rchl Thanks |
pi0
pushed a commit
that referenced
this pull request
Jun 4, 2019
|
@pimlie No, I'm not using nested routes (nuxtChild I presume). It only happened once though and it is nothing given number of requests. I get strangest errors reported by Sentry browser client anyway... |
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
After PR #5746, which has added code to remove trailing slash
in non-strict mode, I've gotten exception reported through Sentry due to
trying to get proper 'path' of undefined 'matchedRoute' object.
I don't know how it happens but it's clear error as code above checks
for null
matchedRoutebut not the code that checks for trailing slash.Made the logic so that non-replaced path is returned when no route
matches. Same as before original fix.
Follow-up fix to #5593
Checklist: