feat(webpack): add webpack:config hook
#6350
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6350 +/- ##
==========================================
+ Coverage 95.71% 95.72% +<.01%
==========================================
Files 79 79
Lines 2662 2665 +3
Branches 685 685
==========================================
+ Hits 2548 2551 +3
Misses 98 98
Partials 16 16
Continue to review full report at Codecov.
|
packages/webpack/src/builder.js
Outdated
| @@ -57,6 +57,10 @@ export class WebpackBundler { | |||
| webpackConfigs.push(this.getWebpackConfig('Server')) | |||
| } | |||
|
|
|||
| const additionalConfigs = [] | |||
| await this.buildContext.nuxt.callHook('build:config', additionalConfigs) | |||
There was a problem hiding this comment.
Why not just pass webpackConfigs? And also a ref to the builder?
For hacking purposes it would be interesting to just have access to everything.
There was a problem hiding this comment.
We've already provided extend for customising, I'm wondering it we should expose here again.
There was a problem hiding this comment.
Probably we can use this hook to implement extend directly
There was a problem hiding this comment.
I added webpackConfigs for now, let's see further comments
TheAlexLichter
changed the title
pi0
changed the title
webpack:config hook
Types of changes
Description
I didn't add any param for now since we already have extend for customising webpack config and this hook should avoid introducing more side effects.
Checklist: