Skip to content

examples(with-sockets): create server inside export function #6396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2019
Merged

examples(with-sockets): create server inside export function #6396

merged 1 commit into from
Sep 11, 2019

Conversation

radimhornicek
Copy link

@radimhornicek radimhornicek commented Sep 11, 2019

It should be within export defaults function () {} to proper this dependency otherwise not working (this = undefined)

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

It should be within export defaults function () {} to proper this dependency
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pi0 pi0 changed the title Scope fix in with-socket example examples(with-sockets): create server inside export function Sep 11, 2019
@pi0 pi0 merged commit 0e0149d into nuxt:dev Sep 11, 2019
@codecov-io
Copy link

Codecov Report

Merging #6396 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6396   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          79       79           
  Lines        2689     2689           
  Branches      694      694           
=======================================
  Hits         2571     2571           
  Misses        101      101           
  Partials       17       17
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.79% <ø> (ø) ⬆️
#unit 92.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e34632...835506d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants