fix(utils): error when router.trailingSlash is false #6515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6515 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 79 79
Lines 2706 2706
Branches 698 698
=======================================
Hits 2589 2589
Misses 101 101
Partials 16 16
Continue to review full report at Codecov.
|
packages/utils/src/route.js
Outdated
| @@ -177,6 +177,9 @@ export const createRoutes = function createRoutes ({ | |||
| if (trailingSlash !== undefined) { | |||
| route.pathToRegexpOptions = { ...route.pathToRegexpOptions, strict: true } | |||
| route.path = route.path.replace(/\/+$/, '') + (trailingSlash ? '/' : '') | |||
| if (route.path === '') { | |||
There was a problem hiding this comment.
how about?
route.path = route.path.replace(/\/+$/, '') + (trailingSlash ? '/' : '') || '/'
There was a problem hiding this comment.
looks good.
I'll adopt this way, thx!
TheAlexLichter
approved these changes
Oct 8, 2019
|
LGTM! We should definitely make sure that users don't trip here like I did 🙈 - #6339 |
pi0
changed the title
pi0
changed the title
Merged
This was referenced Nov 12, 2019
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Fix #6501
Checklist: