perf(vue-renderer): early return render when redirect happens
#6973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
render when redirect happens
pi0
approved these changes
Feb 16, 2020
clarkdo
approved these changes
Feb 16, 2020
Merged
This was referenced Mar 20, 2020
This was referenced Mar 28, 2020
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
In pure ssr mode (ie not nuxt-generate) its not needed to return a full nuxt app on redirecting. A header with Location and empty body is plenty enough.
While debugging a redirect issue yesterday I was confused by this for a long time because I wasnt expecting the full body to be present so was thinking that it had already rendered the next page.
Checklist: