Skip to content

Commit 9ca213b

Browse files
committed
fix(InputMenu/SelectMenu): remove valueKey string case
Resolves #3949 Regression of #3331
1 parent 3484832 commit 9ca213b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/runtime/components/InputMenu.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ const createItem = computed(() => {
278278
const newItem = props.valueKey ? { [props.valueKey]: searchTerm.value } as NestedItem<T> : searchTerm.value
279279
280280
if ((typeof props.createItem === 'object' && props.createItem.when === 'always') || props.createItem === 'always') {
281-
return !filteredItems.value.find(item => compare(item, newItem, String(props.valueKey)))
281+
return !filteredItems.value.find(item => compare(item, newItem, props.valueKey as string))
282282
}
283283
284284
return !filteredItems.value.length
@@ -499,7 +499,7 @@ defineExpose({
499499
v-else
500500
:class="ui.item({ class: props.ui?.item })"
501501
:disabled="isInputItem(item) && item.disabled"
502-
:value="props.valueKey && isInputItem(item) ? get(item, String(props.valueKey)) : item"
502+
:value="props.valueKey && isInputItem(item) ? get(item, props.valueKey as string) : item"
503503
@select="onSelect($event, item)"
504504
>
505505
<slot name="item" :item="(item as NestedItem<T>)" :index="index">

src/runtime/components/SelectMenu.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ const createItem = computed(() => {
275275
const newItem = props.valueKey ? { [props.valueKey]: searchTerm.value } as NestedItem<T> : searchTerm.value
276276
277277
if ((typeof props.createItem === 'object' && props.createItem.when === 'always') || props.createItem === 'always') {
278-
return !filteredItems.value.find(item => compare(item, newItem, String(props.valueKey)))
278+
return !filteredItems.value.find(item => compare(item, newItem, props.valueKey as string))
279279
}
280280
281281
return !filteredItems.value.length

0 commit comments

Comments
 (0)