feat(#2349): add "right_align" option for renderer.icons.*_placement #2846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using ext_marks nvim api
… using ext_marks nvim api feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api
evertonse
changed the title
evertonse
changed the title
…full_name features
evertonse
force-pushed
the
feat/icon_placement-right_align
branch
from
bde9b46 to
cb56c0d
Compare
evertonse
changed the title
right_align and full_name feature
alex-courtis
requested changes
Jul 27, 2024
| @@ -13,12 +13,13 @@ local M = {} | |||
| local SIGN_GROUP = "NvimTreeRendererSigns" | |||
|
|
|||
| local namespace_id = vim.api.nvim_create_namespace "NvimTreeHighlights" | |||
| local namespace_extmarks_id = vim.api.nvim_create_namespace "NvimTreeExtmarks" | |||
There was a problem hiding this comment.
Nice find.
Could we play this a bit safer and have a separate namespace for full-name as well?
It's using "NvimTreeHighlights" which is a little concerning now that we've learned of the namespace sharing difficulties.
There was a problem hiding this comment.
Would be nice to rename it too, indeed, doesn't have to happen here though.
There was a problem hiding this comment.
I looked at the the namespace usage in full_name.lua, and it seems to rely on the NvimTreeHighlights namespace being set up beforehand. I thought this because of line 69:
local extmarks = vim.api.nvim_buf_get_extmarks(0, ns_id, { line_nr - 1, 0 }, { line_nr - 1, -1 }, { details = true })Because of that I don't think I can introduce a separate namespace for full_name rn, also
I did not wrote any code in that file I'm not so sure what I could safely change.
There was a problem hiding this comment.
Fair enough; there may all sorts of assumptions there.
alex-courtis
approved these changes
Jul 28, 2024
alex-courtis
changed the title
right_align and full_name feature
evertonse
added a commit
to evertonse/nvim-tree.lua
that referenced
this pull request
Jul 28, 2024
…lacement (nvim-tree#2846) * feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api * feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api * feat(icon_placement): consolidate doc * fix: extra namespace added to avoid colision between right_align and full_name features * style: rename namespace_id --------- Co-authored-by: Alexander Courtis <[email protected]>
alex-courtis
added a commit
that referenced
this pull request
Aug 10, 2024
…files below the tree (#2856) * feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api * feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api * feat(icon_placement): consolidate doc * fix: extra namespace added to avoid colision between right_align and full_name features * feat(hidden_display): Allow fine grained rendering of hidden files in a folder * feat(hidden_display): update defaults in Builder to allow rendering * feat(hidden_display): Rename opts function name for the feature * feat(#2349): add "right_align" option for renderer.icons.*_placement (#2846) * feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api * feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api feat(icon_placement): Allow right_align icon_placemente for decorator using ext_marks nvim api * feat(icon_placement): consolidate doc * fix: extra namespace added to avoid colision between right_align and full_name features * style: rename namespace_id --------- Co-authored-by: Alexander Courtis <[email protected]> * docs: update docs * feat(hidden_display): Simplification and better performance by not sorting and grouping virtual lines * Update doc/nvim-tree-lua.txt Co-authored-by: Alexander Courtis <[email protected]> * style: hidden_stats is better * docs: change to hidden_stats * add separate namespace for virtual lines * help: add highlight group --------- Co-authored-by: Alexander Courtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The feature from PR #2839 was merged but quickly reverted due to a bug caused by a namespace collision with
full_namerendering whenrenderer.full_nameis enabled. This PR addresses the issue by adding a separate namespace and also syncs with the current nvim-tree master branch.