add Valgrind test script and run it from CI; fix issues in tests

closes #72

Author: vaind

.github/workflows/dart.yml

@@ -1,12 +1,16 @@
 name: Build and test
 
-on: [push, pull_request]
+on: [ push, pull_request ]
+
+defaults:
+  run:
+    shell: bash
 
 jobs:
   generator:
     runs-on: ubuntu-20.04
     container:
-      image:  google/dart:latest
+      image: google/dart:latest
     steps:
       - uses: actions/checkout@v1
       - name: Install ObjectBox C-API
@@ -15,17 +19,31 @@ jobs:
         run: ./generator/test.sh
 
   lib:
-    needs: generator
     runs-on: ubuntu-20.04
     container:
-      image:  google/dart:latest
+      image: google/dart:latest
     steps:
       - uses: actions/checkout@v1
       - name: Install ObjectBox C-API
         run: ./install.sh
-      - name: Install dependencies
-        run: pub get
       - name: Generate ObjectBox models
         run: pub run build_runner build
       - name: Run tests
         run: pub run test
+
+  valgrind:
+    runs-on: ubuntu-20.04
+    container:
+      image: google/dart:latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: Install ObjectBox C-API
+        run: ./install.sh
+      - run: pub get
+      - name: Install Valgrind
+        run: |
+          apt update
+          apt install -y valgrind
+      - name: Generate ObjectBox models
+        run: pub run build_runner build
+      - run: ./tool/valgrind.sh

Makefile

@@ -1,7 +1,7 @@
 # Default target executed when no arguments are given to make.
 default: all
 
-.PHONY: default help depend test publish integration-test
+.PHONY: default help depend test valgrind-test publish integration-test
 
 help:			## Show this help
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
@@ -18,6 +18,10 @@ test: 			## Test all targets
 	pub run build_runner build
 	pub run test
 
+valgrind-test: 		## Test all targets with valgrind
+	pub run build_runner build
+	./tool/valgrind.sh
+
 integration-test:	## Execute integration tests
 	cd example/flutter/objectbox_demo/						; \
 	flutter pub get											; \

test/query_property_test.dart

@@ -118,6 +118,8 @@ void main() {
     final qp = query.property(tString);
     expect(qp is StringPropertyQuery, true);
     qp.close();
+
+    query.close();
   });
 
   final add = (a, b) => a + b;
@@ -415,6 +417,8 @@ void main() {
     queryAndCheck(tShort, -2, 'short null->negative');
     queryAndCheck(tInt, -2, 'int null->negative');
     queryAndCheck(tLong, -2, 'long null->negative');
+
+    queryStrings.close();
   });
 
   test('.find() replace null floats', () {
@@ -431,6 +435,8 @@ void main() {
 
     queryAndCheck(tDouble, 1337.0, 'null double');
     queryAndCheck(tFloat, 1337.0, 'null float');
+
+    queryIntegers.close();
   });
 
   test('.find() replace null strings', () {
@@ -441,6 +447,7 @@ void main() {
     final qp = queryFloats.stringProperty(tString);
     expect(qp.find(replaceNullWith: 't').first, 't');
     qp.close();
+    queryFloats.close();
   });
 
   test('.distinct, .count, .close property query', () {

test/query_test.dart

@@ -41,6 +41,8 @@ void main() {
 
     expect(q.count(), 1);
     expect(q.findFirst().ignore, null);
+
+    q.close();
   });
 
   test('ignore multiple transient fields', () {
@@ -60,6 +62,8 @@ void main() {
     expect(q.count(), 1);
     expect(result.disregard, null);
     expect(result.omit, null);
+
+    q.close();
   });
 
   test('.null and .notNull', () {
@@ -290,11 +294,12 @@ void main() {
     box.put(TestEntity(tString: largeString));
     box.put(TestEntity(tString: largeString));
 
-    List<TestEntity> items =
-        box.query(TestEntity_.id.lessThan(3)).build().find();
+    final query = box.query(TestEntity_.id.lessThan(3)).build();
+    List<TestEntity> items = query.find();
     expect(items.length, 2);
     expect(items[0].tString, largeString);
     expect(items[1].tString, largeString);
+    query.close();
   });
 
   test('.remove deletes the right items', () {

test/stream_test.dart

@@ -47,6 +47,7 @@ void main() {
     expect(result, ['Hello world', 'for now, Goodbye, Hello world']);
 
     await subscription.cancel();
+    query.close();
   });
 
   test('Subscribe to stream of query', () async {
@@ -72,6 +73,7 @@ void main() {
     expect(result, [1, 3]);
 
     await subscription.cancel();
+    query.close();
   });
 
   test(

tool/valgrind.sh

@@ -0,0 +1,38 @@
+. "$(dirname "$0")"/common.sh
+
+if [[ "$#" -gt "1" ]]; then
+  echo "usage: $0 [test name]"
+  echo "e.g. $0"
+  echo "or   $0 query"
+  exit 1
+fi
+
+testDir="${root}/build/test/valgrind"
+rm -rf "${testDir}"
+mkdir -pv "${testDir}"
+cd "${testDir}" || exit 1
+
+
+function testWithValgrind() {
+  echo "Running $1 with valgrind"
+
+  dart2native "${root}/test/${1}" --output ./test --verbose
+  valgrind --show-mismatched-frees=no --leak-check=full --error-exitcode=1 ./test
+
+  echo "$1 successful - no errors reported by valgrind"
+  echo "--------------------------------------------------------------------------------"
+}
+
+if [[ "$#" -gt "0" ]]; then
+  testWithValgrind "${1}_test.dart"
+else
+  for file in "${root}/test/"*_test.dart
+  do
+    testWithValgrind $(basename $file)
+  done
+  find "${root}/test/" -name "*_test.dart" -type f -exec testWithValgrind {} \;
+fi
+
+echo "Test passed, cleaning up"
+cd "${root}" || exit 1
+rm -rf "${testDir}"