Skip to content

Commit c98e56d

Browse files
committed
default tip for auto
1 parent 42f5d9f commit c98e56d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+88
-6
lines changed

src/marks/auto.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,8 @@ export function autoSpec(data, options) {
133133
y: Y ?? undefined, // treat null y as undefined for implicit stack
134134
[colorMode]: C ?? colorColor,
135135
z: Z,
136-
r: S ?? undefined // treat null size as undefined for default constant radius
136+
r: S ?? undefined, // treat null size as undefined for default constant radius
137+
tip: true
137138
};
138139
let transformImpl;
139140
let transformOptions = {[colorMode]: colorReduce ?? undefined, r: sizeReduce ?? undefined};

test/marks/auto-test.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ it("Plot.autoSpec makes a histogram from a quantitative dimension", () => {
1919
y: undefined,
2020
fill: undefined,
2121
z: undefined,
22-
r: undefined
22+
r: undefined,
23+
tip: true
2324
},
2425
transformImpl: "binX",
2526
transformOptions: {fill: undefined, r: undefined, y: "count"},
@@ -45,7 +46,8 @@ it("Plot.autoSpec makes a bar chart from an ordinal dimension", () => {
4546
y: undefined,
4647
fill: "blue",
4748
z: undefined,
48-
r: undefined
49+
r: undefined,
50+
tip: true
4951
},
5052
transformImpl: "groupX",
5153
transformOptions: {fill: undefined, r: undefined, y: "count"},
@@ -75,7 +77,8 @@ it("Plot.autoSpec makes a line from a monotonic dimension", () => {
7577
y: Object.assign([1, 1, 38], {label: "value"}),
7678
stroke: undefined,
7779
z: undefined,
78-
r: undefined
80+
r: undefined,
81+
tip: true
7982
},
8083
transformImpl: undefined,
8184
transformOptions: {stroke: undefined, r: undefined},
@@ -105,7 +108,8 @@ it("Plot.autoSpec makes a dot plot from two quantitative dimensions", () => {
105108
y: Object.assign([0, 3, 2], {label: "y"}),
106109
stroke: undefined,
107110
z: undefined,
108-
r: undefined
111+
r: undefined,
112+
tip: true
109113
},
110114
transformImpl: undefined,
111115
transformOptions: {stroke: undefined, r: undefined},
@@ -138,7 +142,8 @@ it("Plot.autoSpec makes a faceted heatmap", () => {
138142
y: {value: Object.assign([0, 3, 2, 1, 6, 2], {label: "y"})},
139143
fill: undefined,
140144
z: undefined,
141-
r: undefined
145+
r: undefined,
146+
tip: true
142147
},
143148
transformImpl: "bin",
144149
transformOptions: {fill: "count", r: undefined},

test/output/autoArea.svg

Lines changed: 1 addition & 0 deletions
Loading

test/output/autoAreaColor.svg

Lines changed: 1 addition & 0 deletions
Loading

test/output/autoAreaColorColor.svg

Lines changed: 1 addition & 0 deletions
Loading

test/output/autoAreaColorName.svg

Lines changed: 1 addition & 0 deletions
Loading

test/output/autoAreaColorValue.svg

Lines changed: 1 addition & 0 deletions
Loading

test/output/autoAreaStackColor.svg

Lines changed: 1 addition & 0 deletions
Loading

test/output/autoAutoHistogram.svg

Lines changed: 1 addition & 0 deletions
Loading

test/output/autoBar.svg

Lines changed: 1 addition & 0 deletions
Loading

0 commit comments

Comments
 (0)