From 4c74bf0792f1d6aed1bd29593a83112d66d2b8ee Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 15 Feb 2023 10:50:21 +0100 Subject: [PATCH 1/3] fix: add duplex option when sending a body --- src/fetch-wrapper.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/fetch-wrapper.ts b/src/fetch-wrapper.ts index 7325a6ee3..e860d13ad 100644 --- a/src/fetch-wrapper.ts +++ b/src/fetch-wrapper.ts @@ -39,6 +39,7 @@ export default function fetchWrapper( body: requestOptions.body, headers: requestOptions.headers as HeadersInit, redirect: requestOptions.redirect, + ...(requestOptions.body && { duplex: 'half' }) }, // `requestOptions.request.agent` type is incompatible // see https://github.com/octokit/types.ts/pull/264 From 163a55850b6fd1140e50e337a0480ec9d7d38cf9 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 15 Feb 2023 20:11:13 +0100 Subject: [PATCH 2/3] chore: add explanatory comment --- src/fetch-wrapper.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/fetch-wrapper.ts b/src/fetch-wrapper.ts index e860d13ad..1081f60ed 100644 --- a/src/fetch-wrapper.ts +++ b/src/fetch-wrapper.ts @@ -39,6 +39,8 @@ export default function fetchWrapper( body: requestOptions.body, headers: requestOptions.headers as HeadersInit, redirect: requestOptions.redirect, + // duplex must be set if request.body is ReadableStream or Async Iterables. + // See https://fetch.spec.whatwg.org/#dom-requestinit-duplex. ...(requestOptions.body && { duplex: 'half' }) }, // `requestOptions.request.agent` type is incompatible From 6d5342d18f53d06a5d0d0538438a3286377ef371 Mon Sep 17 00:00:00 2001 From: Gregor Martynus <39992+gr2m@users.noreply.github.com> Date: Wed, 15 Feb 2023 12:57:53 -0800 Subject: [PATCH 3/3] style: prettier --- src/fetch-wrapper.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fetch-wrapper.ts b/src/fetch-wrapper.ts index 1081f60ed..fe3e7ef2b 100644 --- a/src/fetch-wrapper.ts +++ b/src/fetch-wrapper.ts @@ -41,7 +41,7 @@ export default function fetchWrapper( redirect: requestOptions.redirect, // duplex must be set if request.body is ReadableStream or Async Iterables. // See https://fetch.spec.whatwg.org/#dom-requestinit-duplex. - ...(requestOptions.body && { duplex: 'half' }) + ...(requestOptions.body && { duplex: "half" }), }, // `requestOptions.request.agent` type is incompatible // see https://github.com/octokit/types.ts/pull/264