[FIX] Show stderr during build process

According to pull request odoo/odoo#4039 we
should log into stderr. Therefore, the stderr output of build should be
logged too.

Author: Samus CTO

runbot/runbot.py

@@ -697,7 +697,7 @@ def cmd(self, cr, uid, ids, context=None):
 
         return cmd, modules
 
-    def spawn(self, cmd, lock_path, log_path, cpu_limit=None, shell=False, showstderr=False):
+    def spawn(self, cmd, lock_path, cpu_limit=None, **kwargs):
         def preexec_fn():
             os.setsid()
             if cpu_limit:
@@ -709,13 +709,8 @@ def preexec_fn():
             # close parent files
             os.closerange(3, os.sysconf("SC_OPEN_MAX"))
             lock(lock_path)
-        out=open(log_path,"w")
-        _logger.debug("spawn: %s stdout: %s", ' '.join(cmd), log_path)
-        if showstderr:
-            stderr = out
-        else:
-            stderr = open(os.devnull, 'w')
-        p=subprocess.Popen(cmd, stdout=out, stderr=stderr, preexec_fn=preexec_fn, shell=shell)
+        _logger.debug("spawn: %s", ' '.join(cmd))
+        p=subprocess.Popen(cmd, preexec_fn=preexec_fn, **kwargs)
         return p.pid
 
     def github_status(self, cr, uid, ids, context=None):
@@ -759,19 +754,23 @@ def job_10_test_base(self, cr, uid, build, lock_path, log_path):
         cmd, mods = build.cmd()
         if grep(build.server("tools/config.py"), "test-enable"):
             cmd.append("--test-enable")
-        cmd += ['-d', '%s-base' % build.dest, '-i', 'base', '--stop-after-init', '--log-level=test', '--max-cron-threads=0']
-        return self.spawn(cmd, lock_path, log_path, cpu_limit=300)
+        cmd += ['-d', '%s-base' % build.dest, '-i', 'base',
+                '--log-level=test', '--logfile=%s' % log_path,
+                '--stop-after-init', '--max-cron-threads=0']
+        return self.spawn(cmd, lock_path, cpu_limit=300)
 
     def job_20_test_all(self, cr, uid, build, lock_path, log_path):
         build._log('test_all', 'Start test all modules')
         self.pg_createdb(cr, uid, "%s-all" % build.dest)
         cmd, mods = build.cmd()
         if grep(build.server("tools/config.py"), "test-enable"):
             cmd.append("--test-enable")
-        cmd += ['-d', '%s-all' % build.dest, '-i', mods, '--stop-after-init', '--log-level=test', '--max-cron-threads=0']
+        cmd += ['-d', '%s-all' % build.dest, '-i', mods,
+                '--log-level=test', '--logfile=%s' % log_path,
+                '--stop-after-init', '--max-cron-threads=0']
         # reset job_start to an accurate job_20 job_time
         build.write({'job_start': now()})
-        return self.spawn(cmd, lock_path, log_path, cpu_limit=2100)
+        return self.spawn(cmd, lock_path, cpu_limit=2100)
 
     def job_30_run(self, cr, uid, build, lock_path, log_path):
         # adjust job_end to record an accurate job_20 job_time
@@ -803,7 +802,7 @@ def job_30_run(self, cr, uid, build, lock_path, log_path):
             # not sure, to avoid old server to check other dbs
             cmd += ["--max-cron-threads", "0"]
 
-        cmd += ['-d', "%s-all" % build.dest]
+        cmd += ['-d', "%s-all" % build.dest, '--logfile=%s' % log_path]
 
         if grep(build.server("tools/config.py"), "db-filter"):
             if build.repo_id.nginx:
@@ -823,7 +822,7 @@ def job_30_run(self, cr, uid, build, lock_path, log_path):
         #    f.close()
         #cmd=[self.client_web_bin_path]
 
-        return self.spawn(cmd, lock_path, log_path, cpu_limit=None, showstderr=True)
+        return self.spawn(cmd, lock_path, cpu_limit=None)
 
     def force(self, cr, uid, ids, context=None):
         """Force a rebuild"""